980140 - Add goals field to Create Event template

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[William Reynolds [:williamr]]

When a Rep creates an event, we should require them to specify one or more goals that the event supports.

Specs:
* Error message if no value is selected: "Please select an organizational goal."
* Placement: This field appears immediately before the 'Select event category' field.
* Input type: Could be an overlay with a checkbox for each goal (similar to Select event category) or a combo select box.
* Once this is launched, all new events will be required to have one or more goals.
* Edge case: Once this is launched, events created before this new functionality will not have goals. If an exiting event without a goal is edited, we could require a goal to save the edit or we could allow existing events to be editing without adding a goal. I favor whatever is technically easiest, since this edge case adds little value to measuring goals and events.
* Let's design this list of goal so it can be easily updated. The list of goals will only change a couple times a year, so it does not need to be dynamic and managed through the UI. However, it should be easy for us to add/edit/remove goals from this list.

User stories
* As a user, when I create a new event, I must select one or more organizational goals for my event.
* As a user, when I create/edit an event and do not provide a goal, I am shown an error message and not allowed to create/edit the event.
* As a user, when I edit an event, I can change the goals. I am still required to select one or more goals.

The initial set of goals:
- Scale Firefox OS
- Add Services to our Product Lines
- Get Firefox on a Growth Trajectory
- Invest in Sustainability
- Grow Adoption of Webmaker & Open Badges
- Enable Communities that have Impact

Goals found at https://wiki.mozilla.org/2014

Comment 1

[William Reynolds [:williamr]]

Brian, do all events map to at least one of the goals in comment 0? If not, we could add an 'Other' option. I think this list may cover all events though.

Comment 2

[Brian King [:kinger]]

(In reply to William Reynolds [:williamr] from comment #1)
> Brian, do all events map to at least one of the goals in comment 0? If not,
> we could add an 'Other' option. I think this list may cover all events
> though.

I think they cover everything, yes. I'm not sure we want to include 'Invest in Sustainability' however, as this is not a focus of Reps events as far as I can see. We also might want to change the wording of some or just shorten them.

Comment 3

[William Quiviger [:williamq]]

I think we need to include "Invest in Sustainability" since I anticipate we're going to see more and more Reps working with our Biz Dev team to attract potential partners in their region. 

But I do agree with Brian that leaving the goals as they are written might be a bit challenging for some non-native english speakers to understand. I think what would be very helpful would be to have a little "?" placed to the right of each goal which the Rep can hover over to learn more about the goal. A typical user story would be: 

- As a user, when I am creating my event and I am selecting the org goal(s) that my event supports, I can hover over the "?" next to the goal so learn more about the goal and make sure that I'm selecting the right goal. 

In terms of copy for each "?", we should just use the text located below the goal on the wiki page. 

So for example, if the goal is "Scale Firiefox OS", the text that should appear when hovering over the "?" should be:

"2014 is really critical for Firefox OS. In 2013 we proved the viability of the platform, our ability to deliver it, and the existence of a nascent ecosystem. Now it's really a momentum play to scale Firefox OS in 2014. A question was recently asked in a staff meeting, "Isn't Firefox OS over Horizon 2?" No, it's not over that hump. We've proven that we are the ones who can do this now, but to actually do it is going to take the same kind of concerted effort we've been applying for the past two years. "

Comment 4

[William Reynolds [:williamr]]

Here's an attempt at rewording the goals from comment 0. Brian, can you please finalize the wording you would like to use? 

- Get Firefox OS to more people
- Add Services to Mozilla products
- Grow Firefox desktop usage
- Invest in financial sustainability
- Grow adoption of Webmaker & Open Badges
- Enable communities that have impact

(In reply to William Quiviger [:williamq] from comment #3)
> But I do agree with Brian that leaving the goals as they are written might
> be a bit challenging for some non-native english speakers to understand. I
> think what would be very helpful would be to have a little "?" placed to the
> right of each goal which the Rep can hover over to learn more about the
> goal.

I think this is a great feature enhancement, and I have filed bug 982959 for adding the help text.

The goals field in this bug can be released before the help text is ready, since the help text is an enhancement.

Comment 5

[Brian King [:kinger]]

(In reply to William Reynolds [:williamr] from comment #4)
> - Get Firefox OS to more people
> - Add Services to Mozilla products
> - Grow Firefox desktop usage
> - Invest in financial sustainability
> - Grow adoption of Webmaker & Open Badges
> - Enable communities that have impact

Personally I think they should be even shorter:

- Firefox OS
- Services
- Firefox desktop
- Financial sustainability
- Webmaker & Open Badges
- Enable communities

This could have the side-effect of creating a short-hand, understandable, lexicon of our goals. The help text will provide more context if needed.

Comment 6

[William Reynolds [:williamr]]

The goals listed in comment 5 look great to me.

Tasos, let us know if you have any questions about the specs or goals. If not, go for it!

Comment 7

[Brian King [:kinger]]

IRC Conversation to continue here:

Brian:
So my vision for bug 980140 is that the top levels goals are checkboxes, and they are at the top of the form and span both columns. This has the effect of showing how important they are they set the stage for filling out the rest of the form. Thoughts? I wonder if we could event do something fancy where they are always visible even when the page is scrolled.

William:
I like that vision. It requires a little more frontend work, but it emphasizes how important the goals are
If it would take an extra week or two to have that two-column, always visible UI, how would you feel able releasing it first as just a regular set of check boxes and then releasing the better UI after that?

Brian:
So in the spirit of moving faster, yes let's release first if there is a lot of extra overhead with the 2 column approach. I know you just used it as an example, but I don't think it would take a week or two extra for that layout.

:tasos, let us know your thoughts.

Comment 8

[Tasos Katsoulas [:tasos]]

I am not a UI expert, but my only concern with the two columns approach on the top of the form, is that this might break the balance of the page. On the other hand, since this would be a required field, maybe we could use just a dropdown box or a button like :williamr suggested in the initial specs. Maybe :agibson could provide a bit more helpful input on this.

Comment 9

[Alex Gibson [:agibson]]

(In reply to Tasos Katsoulas [:tasos] from comment #8)
> I am not a UI expert, but my only concern with the two columns approach on
> the top of the form, is that this might break the balance of the page. On
> the other hand, since this would be a required field, maybe we could use
> just a dropdown box or a button like :williamr suggested in the initial
> specs. Maybe :agibson could provide a bit more helpful input on this.

Generally most forms on reps follow a two column approach, which the user follows from top to bottom, left to right. My initial gut feeling is that making this new fieldset span 100% width at the top of a two column form might prove a little confusing visually, and disrupt the flow for the rest of the form. It would largely depend on the messaging and visual appearance I guess.

However, considering that this form is already quite field 'heavy', I quite like Tasos' suggestion of using a single dropdown for this field. When it comes to 'form heavy' sites like Reps I'm all in favor of keeping the UI cleaner and less cluttered.

Comment 10

[William Reynolds [:williamr]]

(In reply to Alex Gibson [:agibson] from comment #9)
> However, considering that this form is already quite field 'heavy', I quite
> like Tasos' suggestion of using a single dropdown for this field. When it
> comes to 'form heavy' sites like Reps I'm all in favor of keeping the UI
> cleaner and less cluttered.

Thanks Alex. Since the goals field lets the user 'specify one or more goals' (comment 0), are you suggesting one or more dropdown fields? Or perhaps a single field allowing multiple selections (like a set of check boxes) would be better?

Comment 11

[Alex Gibson [:agibson]]

(In reply to William Reynolds [:williamr] from comment #10)
> Thanks Alex. Since the goals field lets the user 'specify one or more goals'
> (comment 0), are you suggesting one or more dropdown fields? Or perhaps a
> single field allowing multiple selections (like a set of check boxes) would
> be better?

We could either use a set of check boxes, or a multi-select field (like we do on the new active report creation form). Either way I am fine with (just want to focus on making things as easy as possible) :)

Comment 12

[Brian King [:kinger]]

(In reply to Alex Gibson [:agibson] from comment #11)
> We could either use a set of check boxes, or a multi-select field (like we
> do on the new active report creation form). Either way I am fine with (just
> want to focus on making things as easy as possible) :)

I'm fine with either of these as well.

Comment 13

[Justin Crawford [:hoosteeno] [:jcrawford]]

Tasos will shortly submit a PR for this that answers the question in comment 11, and the dev team agreed to launch with that for now.

Comment 14

[Tasos Katsoulas [:tasos]]

PR opened here [0].

[0] https://github.com/mozilla/remo/pull/671

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/19e7cd4e9fda75949408b9c03fe996569d8799fc
[fix bug 980140] Add goals field in events.

https://github.com/mozilla/remo/commit/c3d6b03bca3ae8554099508775f8a2a84d561568
Merge pull request #671 from akatsoulas/980140

[fix bug 980140] Add goals field in events.

Comment 16

[Giorgos Logiotatidis [:giorgos]]

Verified on stage:
 * Goals list can be easily edited from site settings (not admin panel)
 * Goals can be added, removed, be active / inactive
 * Events require at least one goal
 * Events withs goals that are now inactive can be edited and maintain the already linked inactive goals
 * Existing events must select goals if edited.

Thanks :tasos!

Comment 17

[Brian King [:kinger]]

Did this go out in 426 or 427? I am not seeing it. If so, can someone post a screenshot.

Comment 18

[John Giannelos [:nemo-yiannis]]

Here [1] is a screenshot for the event goal modal on edit event. Also here [2] you can see the event goal settings page. Both are from prod.

[1] http://awesomescreenshot.com/0fd2lfc2e8
[2] http://awesomescreenshot.com/0642lfcia7