980159 - Move inline script in webmaker-auth-client.html into separate file

Status: RESOLVED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[Alexander [:admix]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9

Steps to reproduce:

This script https://github.com/mozilla/goggles.webmaker.org/blob/master/views/webmaker-auth-client.html#L5-L21 should be moved to separate file

Comment 1

[Alexander [:admix]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/109

Moved auth-login script into separate js file.
PR -> https://github.com/mozilla/goggles.webmaker.org/pull/109

Comment 2

[Jon Buckley [:jbuck]]

Comment on attachment 8387345 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/109

r-, notes in the PR

Comment 3

[Alexander [:admix]]

Comment on attachment 8387345 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/109

Fixed and squashed.
PR -> https://github.com/mozilla/goggles.webmaker.org/pull/109

Comment 4

[Jon Buckley [:jbuck]]

Comment on attachment 8387345 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/109

You'll need to edit views/uproot-dialog.html as well

Comment 5

[Alexander [:admix]]

Comment on attachment 8387345 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/109

Fixed uproot-dialog file. squashed.
PR - https://github.com/mozilla/goggles.webmaker.org/pull/109

Comment 6

[Jon Buckley [:jbuck]]

Comment on attachment 8387345 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/109

r+ with nits, you need to remove the async attribute from  both script tags

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/b1bdced671316de5e9760eec9d26b6a3160e7c9d
[bug980159] - Moved auth-login script into separate file

[bug980159] - killed useless html and moved script to index

[bug980159] - replaced html include with linked scripts in views/uproot-dialog

[bug980159] - removed async to load dependencies

https://github.com/mozilla/goggles.webmaker.org/commit/c0fe3fb11ba2663ca78ae1f45f59421b0117a4a2
Merge pull request #109 from admix/bug980159

[bug980159] - Moved auth-login script into separate file