Closed
Bug 980162
Opened 10 years ago
Closed 10 years ago
Move inline script in preferences.html into separate file
Categories
(Webmaker Graveyard :: X-Ray Goggles, defect)
Webmaker Graveyard
X-Ray Goggles
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: admix, Assigned: admix)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9 Steps to reproduce: Move inline script in https://github.com/mozilla/goggles.webmaker.org/blob/master/webxray/static-files/preferences.html#L5-L10 into separate js file
|
Assignee | |
Comment 1•10 years ago
|
||
Moved inline script from preferences.html into separate preferences.js file PR -> https://github.com/mozilla/goggles.webmaker.org/pull/110
Attachment #8387561 -
Flags: review?(jon)
|
||
Updated•10 years ago
|
Attachment #8387561 -
Flags: review?(jon) → review+
|
|
||
Updated•10 years ago
|
Assignee: nobody → admix.snurnikov
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/goggles.webmaker.org https://github.com/mozilla/goggles.webmaker.org/commit/f07b83d28742cf099dd7e1568b8d41e7d5ba2f2a [bug980162] - Moved inline script into separate js file https://github.com/mozilla/goggles.webmaker.org/commit/fe87793ec697724eb3228c006d103e6e255214cc Merge pull request #110 from admix/bug980162 [bug980162] - Moved inline script into separate js file
|
|
||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•