Closed Bug 980163 Opened 7 years ago Closed 6 years ago

Do binary name comparison optimization consistently in mozilla::pkix

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1020683

People

(Reporter: briansmith, Unassigned)

Details

In one place, we use:

  if (!SECITEM_ItemsAreEqual(&cert.GetNSSCert()->derIssuer,
                             &issuerCert.derSubject) &&
      CERT_CompareName(&cert.GetNSSCert()->issuer,
                       &issuerCert.subject) != SECEqual) {

However, in other places we use CERT_CompareName without trying SECItem_ItemsAreEqual first.

We should wrap the SECITEM_ItemsAreEqual/CERT_CompareName calls in a function that is used consistently everywhere.
Summary: Do binary name comparison optimization consistently in insanity::pkix → Do binary name comparison optimization consistently in mozilla::pkix
Bug 1020683 removed the use of CERT_CompareName, so we're now already doing all DirectoryName comparisons consistently in mozilla::pkix.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1020683
You need to log in before you can comment on or make changes to this bug.