Closed Bug 980164 Opened 10 years ago Closed 10 years ago

[System2] LogoLoader Updates

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
logo_loader.js is instantiable, but it does not follow the new system v2 patterns.

Also jshint, unit tests, and jsdoc improvements.
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8387714 [details] [review]
Github pull request

Hey Alive - another easy one. Please review if you have time. Thanks!

        Attachment #8387714 -
        Flags: review?(alive)

    
    

    
  
Comment on attachment 8387714 [details] [review]
Github pull request

Thanks Kevin!

        Attachment #8387714 -
        Flags: review?(alive) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/8c9191df3c107df4073f3ca63816a1d36c51af5d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: