Closed Bug 980186 Opened 7 years ago Closed 7 years ago

Tell automation.environment about the debugger so it can set the crash reporting envs properly

Categories

(Testing :: Reftest, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → jmuizelaar
Attachment #8386564 - Flags: review?(jgriffin) → review+
The relevant part is:
TypeError: environment() got an unexpected keyword argument 'debugger'
Flags: needinfo?(jmuizelaar)
This adds an ignored debugger parameter in b2gautomation so that we don't fail when running there.
Attachment #8386564 - Attachment is obsolete: true
Attachment #8388582 - Flags: review?(jgriffin)
Comment on attachment 8388582 [details] [diff] [review]
Tell automation.environment about the debugger so it can set the crash reporting envs properly

I'm passing this to ahal since he knows the related code better than I.
Attachment #8388582 - Flags: review?(jgriffin) → review?(ahalberstadt)
Comment on attachment 8388582 [details] [diff] [review]
Tell automation.environment about the debugger so it can set the crash reporting envs properly

Review of attachment 8388582 [details] [diff] [review]:
-----------------------------------------------------------------

Did you forget a qref or something? This is a no-op since b2gautomation.environment() method doesn't do anything with the debugger parameter.
Attachment #8388582 - Flags: review?(ahalberstadt) → review-
Comment on attachment 8388582 [details] [diff] [review]
Tell automation.environment about the debugger so it can set the crash reporting envs properly

Review of attachment 8388582 [details] [diff] [review]:
-----------------------------------------------------------------

Oh sorry, didn't see comment 3.
Attachment #8388582 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/40206fb386d9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.