980186 - Tell automation.environment about the debugger so it can set the crash reporting envs properly

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Tell automation.environment about the debugger so it can set the crash reporting envs properly

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2a0130dcdd

But was backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/0486a9d3c32e for breaking everything in the b2g reftest suite. They all failed like this:  https://tbpl.mozilla.org/php/getParsedLog.php?id=35811618&tree=Mozilla-Inbound

Comment 2

[Jeff Muizelaar [:jrmuizel]]

The relevant part is:
TypeError: environment() got an unexpected keyword argument 'debugger'

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Tell automation.environment about the debugger so it can set the crash reporting envs properly

This adds an ignored debugger parameter in b2gautomation so that we don't fail when running there.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8388582 [details] [diff] [review]
Tell automation.environment about the debugger so it can set the crash reporting envs properly

I'm passing this to ahal since he knows the related code better than I.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8388582 [details] [diff] [review]
Tell automation.environment about the debugger so it can set the crash reporting envs properly

Review of attachment 8388582 [details] [diff] [review]:
-----------------------------------------------------------------

Did you forget a qref or something? This is a no-op since b2gautomation.environment() method doesn't do anything with the debugger parameter.

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8388582 [details] [diff] [review]
Tell automation.environment about the debugger so it can set the crash reporting envs properly

Review of attachment 8388582 [details] [diff] [review]:
-----------------------------------------------------------------

Oh sorry, didn't see comment 3.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/40206fb386d9