980236 - [B2G] [RIL] test_ril_worker_icc.js fails with DEBUG = true

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

With debugger enabled, it's expected that "options" has properties as fileId, sw1, sw2, etc. However, [2] doesn't assign those that leads to test failure. 

[1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/tests/test_ril_worker_icc.js?from=test_ril_worker_icc.js&case=true#2117

[2] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/tests/test_ril_worker_icc.js?from=test_ril_worker_icc.js&case=true#2117

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #0)
> With debugger enabled, it's expected that "options" has properties as
> fileId, sw1, sw2, etc. However, [2] doesn't assign those that leads to test
> failure. 
> 

Expected: [1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#11885

> 
> [2]
> http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/tests/
> test_ril_worker_icc.js?from=test_ril_worker_icc.js&case=true#2117

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 980236.patch

Adding properties, fileId, sw1, sw2..., to options.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d8bfd6639646

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8bfd6639646