Open Bug 980244 Opened 7 years ago Updated 4 days ago

Clearing search bar form history doesn't provide any visible feedback

Categories

(Firefox :: Search, defect, P5)

27 Branch
defect

Tracking

()

People

(Reporter: elgatotitou, Unassigned)

References

Details

(Whiteboard: [bug][fxsearch])

Attachments

(1 file)

Attached image screenshot_246.jpg
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

When we try to clear the history search it seems to be okay with FF22 in the menu it goes to "grey" (the text cannot be clicked. That is a "confirmation" it's cleared)


Actual results:

Since FF23 to the lastest stable 27.0.1 the problem is that it doesn't go to grey (you'll see on the screenshot cause my explain could not be perfect). The history search is cleared but no change for the text.


Expected results:

Normally it must do like Firefox 22 so the text goes to grey when the history search has been cleared.
Hardware: x86 → x86_64
This is reproducible in Firefox stable, beta, Nightly, and Aurora.
Status: UNCONFIRMED → NEW
Component: Untriaged → Search
Ever confirmed: true
OS: Mac OS X → All
Hardware: x86_64 → All
This is fallout from http://hg.mozilla.org/mozilla-central/rev/555f2b757639#l8.92

We can't tell synchronously that there's no more history to clear, so we just punted and always assumed there was.

I don't think there's any good way for us to fix this, short of keeping track of form history "dirty" state out of band with notifications and such. That seems like more trouble than it's worth...
Summary: clear history search (from the right by search Engine) → clearing search bar form history doesn't provide any visible feedback
the FormHistory component could expose an async method to tell if there's any data and the menuitem could be initially disabled and then enabled asynchronously if there's data.
ops, I said form history but I meant search service :/
It would actually be form history in this case. That's kind of where I was going with "keeping track of form history "dirty" state out of band with notifications and such", but I'm just not sure it's worth the effort.
Flags: firefox-backlog+
Whiteboard: p=2
Points: --- → 2
Whiteboard: p=2
Rank: 55
Priority: -- → P5
Whiteboard: [bug][fxsearch]
Severity: normal → S4
Points: 2 → ---
Rank: 55
Summary: clearing search bar form history doesn't provide any visible feedback → Clearing search bar form history doesn't provide any visible feedback
You need to log in before you can comment on or make changes to this bug.