980278 - Remove DataContainerEvent dependency from Mochitest

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

I'm going to hide DataContainerEvent from content in bug 980134.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8386740 [details] [diff] [review]
patch

Review of attachment 8386740 [details] [diff] [review]:
-----------------------------------------------------------------

please test on try server with all desktop, android, and b2g combinations.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: patch v2

> please test on try server with all desktop, android, and b2g combinations.

The test found a critical patch error. |event.detail| was read-only once the event was created.

Try runs with the new patch:
https://tbpl.mozilla.org/?tree=Try&rev=60b58c4ea9e2
https://tbpl.mozilla.org/?tree=Try&rev=81580be40d79

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8388029 [details] [diff] [review]
patch v2

Review of attachment 8388029 [details] [diff] [review]:
-----------------------------------------------------------------

I am not familiar with CustomEvent, reading the entry on MDN appears to do what we need.  Have you tested this on try?

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Joel Maher (:jmaher) from comment #3)
> Have you tested this on try?

Yes. See the last paragraph of comment #2.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

thanks!

Comment 6

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66006ee3eb18

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66006ee3eb18