Closed Bug 980278 Opened 8 years ago Closed 8 years ago

Remove DataContainerEvent dependency from Mochitest

Categories

(Testing :: Mochitest, defect)

Product:
Testing
Component:
Mochitest
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
3.56 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
I'm going to hide DataContainerEvent from content in bug 980134.
Attachment #8386740 - Flags: review?(jmaher)
Comment on attachment 8386740 [details] [diff] [review]
patch

Review of attachment 8386740 [details] [diff] [review]:
-----------------------------------------------------------------

please test on try server with all desktop, android, and b2g combinations.
Attachment #8386740 - Flags: review?(jmaher) → review+
Attached patch patch v2 — — Splinter Review 
> please test on try server with all desktop, android, and b2g combinations.

The test found a critical patch error. |event.detail| was read-only once the event was created.

Try runs with the new patch:
https://tbpl.mozilla.org/?tree=Try&rev=60b58c4ea9e2
https://tbpl.mozilla.org/?tree=Try&rev=81580be40d79
Attachment #8386740 - Attachment is obsolete: true
Attachment #8388029 - Flags: review?(jmaher)
Comment on attachment 8388029 [details] [diff] [review]
patch v2

Review of attachment 8388029 [details] [diff] [review]:
-----------------------------------------------------------------

I am not familiar with CustomEvent, reading the entry on MDN appears to do what we need.  Have you tested this on try?
Attachment #8388029 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #3)
> Have you tested this on try?

Yes. See the last paragraph of comment #2.
https://hg.mozilla.org/integration/mozilla-inbound/rev/66006ee3eb18
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/66006ee3eb18
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.