Closed
Bug 980346
Opened 10 years ago
Closed 7 years ago
Make session store tests deterministic
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: Irving, Unassigned)
References
Details
(Whiteboard: [lang=js])
The session store patch in bug 894793 introduces a test with timers, rather than using a deterministic wait for the asynchronous operation being tested. See https://bugzilla.mozilla.org/show_bug.cgi?id=894793#c25 for a strategy to make these test deterministic.
|
Assignee | |
Updated•10 years ago
|
Mentor: irving
Whiteboard: [mentor=irving][lang=js] → [lang=js]
|
Reporter | |
Updated•10 years ago
|
Mentor: irving
In Bug 1358906 session store was converted to use JSONFile apis. The load part in tests is now deterministic, as it can await a promise. The store part cannot be, as the api does not return a promise and a caller must use saveSoon() to get shutdown handling, and that merely pops a timer. Toolkit has enough tests of JSONFile though.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•