Closed
Bug 980379
Opened 11 years ago
Closed 11 years ago
AppsUtils.loadJSONAsync() should allow passing options to OS.File calls
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.70 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
AppsUtils.loadJSONAsync() should allow passing options to OS.File calls so e.g. compression can be used.
| Assignee | ||
Comment 1•11 years ago
|
||
fabrice, "hg log" suggests you as a reviewer.
This allows me to use |loadJSONAsync(path, {compression: "lz4"})|.
Assignee: nobody → georg.fritzsche
Status: NEW → ASSIGNED
Attachment #8386863 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #8386863 -
Flags: review?(fabrice) → review+
Comment 2•11 years ago
|
||
We'll stop using OS.File for now because of some problems with b2g (see bug 961317 for details).
| Assignee | ||
Comment 3•11 years ago
|
||
Thanks for the heads-up. As it seems this is just B2G-test-specific for now i might just roll my own version if i land before bug 961317 is fixed.
Depends on: 961317
Comment 4•11 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> Thanks for the heads-up. As it seems this is just B2G-test-specific for now
> i might just roll my own version if i land before bug 961317 is fixed.
I think in bug 981085 we're going to remove this function altogether.
| Assignee | ||
Comment 5•11 years ago
|
||
Alright, then let's not spend time on this.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•