980381 - Install node && npm on mountainlion test slaves

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Jonathan Griffin (:jgriffin)]

We need to run gaia-integration tests on OSX test slaves, but apparently they don't have npm (and so I guess they don't have node either):

20:03:43     INFO - Running command: ['npm', 'cache', 'clean']
20:03:43     INFO - Copy/paste: npm cache clean
20:03:43    ERROR - caught OS error 2: No such file or directory while running ['npm', 'cache', 'clean']

https://tbpl.mozilla.org/php/getParsedLog.php?id=35699217&tree=Cedar&full=1#error0

This is relatively high urgency, as some people would like to end our dependency on Travis, but we can't as long as Gi tests aren't running in TBPL.

Comment 1

[Jonathan Griffin (:jgriffin)]

This bug is an analog to https://bugzilla.mozilla.org/show_bug.cgi?id=931875, where the same thing was done for Ubuntu VM slaves.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Well, that was pretty easy:

Notice: /Stage[main]/Packages::Nodejs/Packages::Pkgdmg[nodejs]/Package[nodejs-0.10.21.dmg]/ensure: created

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug980381.patch

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8386877 [details] [diff] [review]
bug980381.patch

Review of attachment 8386877 [details] [diff] [review]:
-----------------------------------------------------------------

stamp

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8386877 [details] [diff] [review]
bug980381.patch

merged to prod

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Huh, on mountain lion:

Error: Execution of '/usr/sbin/installer -pkg /private/tmp/dmg.fWjjc1/nodejs-0.10.21.pkg -target /' returned 1: installer: Package name is Node
installer: Certificate used to sign package is not trusted. Use -allowUntrusted to override.

backed out.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Works fine on snow leopard, too.  This is an Apple bug on Mountain Lion, fixed in 10.8.3.

However, using pkgutil to expand and re-flatten the package seems to help.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug980381-p1.patch

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 8389284 [details] [diff] [review]
bug980381-p1.patch

Review of attachment 8389284 [details] [diff] [review]:
-----------------------------------------------------------------

just to mention nodejs install will fail on a talos instantiated windows host with this patch (though I don't think thats the only windows problem we'd have here)

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Yes, we'd need to move this back to a per-OS category, but that's not hard.