980392 - Storable error generating when create etags for Bug.get under certain circumstances

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[David Lawrence [:dkl]]

Bug.get is passing \@bugs to $self->bz_etag instead of \@hashes and in certain circumstances the following error is generated:

Error:

{
  "finish_timestamp": 0, 
  "request_timestamp": 1394114885.3151, 
  "requestid": 48351760, 
  "start_timestamp": 0, 
  "state": 3, 
  "text": "(u\"Can't store CODE items at ../../lib/Storable.pm (autosplit into ../../lib/auto/Storable/_freeze.al) line 339, at /data/www/bugzilla-dev.allizom.org/Bugzilla/WebService/Server.pm line 81\\n\", {u'message': u\"Can't store CODE items at ../../lib/Storable.pm (autosplit into ../../lib/auto/Storable/_freeze.al) line 339, at /data/www/bugzilla-dev.allizom.org/Bugzilla/WebService/Server.pm line 81\\n\", u'code': 100500, u'error': True})"
}

Fix:


=== modified file 'Bugzilla/WebService/Bug.pm'
--- Bugzilla/WebService/Bug.pm	2014-02-27 08:48:50 +0000
+++ Bugzilla/WebService/Bug.pm	2014-03-06 15:59:35 +0000
@@ -411,7 +411,7 @@
     # Set the ETag before inserting the update tokens
     # since the tokens will always be unique even if
     # the data has not changed.
-    $self->bz_etag(\@bugs);
+    $self->bz_etag(\@hashes);
 
     $self->_add_update_tokens($params, \@bugs, \@hashes);


Patch coming
dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 980392_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8386874 [details] [diff] [review]
980392_1.patch

r=glob

Comment 3

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/WebService/Bug.pm
Committed revision 8951.