980419 - Preferences should not be allowed to be accessed off of the main thread on b2g.

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

+++ This bug was initially created as a clone of Bug #619487 +++

B2G still needs some love here.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: omt-pref-memdump.patch

This removes the memory_info_dumper.watch_fifo.directory OMT access.

I still see gfx.apitrace.enabled and gl.msaa-level.

Comment 3

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/be4f47078f6f

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/be4f47078f6f

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This bug still requires removing the #ifndef MOZ_B2G conditions in https://hg.mozilla.org/mozilla-central/rev/c50ed2757551 , right?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Or do the other 2 from comment 1 still need to be fixed first as well?)

Comment 7

[[:fabrice] Fabrice Desré]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #6)
> (Or do the other 2 from comment 1 still need to be fixed first as well?)

I think so. I should have filed this one as a dependency instead of hijacking the whole bug :(

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to [:fabrice] Fabrice Desré from comment #1)
> Created attachment 8387901 [details] [diff] [review]
> omt-pref-memdump.patch
> 
> This removes the memory_info_dumper.watch_fifo.directory OMT access.
> 
> I still see gfx.apitrace.enabled and gl.msaa-level.

These off main thread accesses were fixed, but b2g add 'dom.ipc.processPrelaunch.testMode' as off main thread access.

https://dxr.mozilla.org/mozilla-central/source/ipc/glue/MessageLink.cpp#148

The following is a tryserver result.
 https://treeherder.mozilla.org/logviewer.html#?job_id=11317921&repo=try

Comment 9

[Sotaro Ikeda [:sotaro]]

:cyu, can 'dom.ipc.processPrelaunch.testMode' be changed not to be accessed from off main thread? Bug 977359 add it.

Comment 10

[Cervantes Yu [:cyu] [:cervantes]]

(In reply to Sotaro Ikeda [:sotaro] from comment #9)
> :cyu, can 'dom.ipc.processPrelaunch.testMode' be changed not to be accessed
> from off main thread? Bug 977359 add it.

Yes. I opened bug 1204455 for it.

Comment 11

[:Gijs (he/him)]

All the deps are fixed, can we just get rid of the ifdefs for B2G now, or is there more that needs to be done here?