Closed Bug 980419 Opened 6 years ago Closed 2 years ago

Preferences should not be allowed to be accessed off of the main thread on b2g.

Categories

(Core :: Preferences: Backend, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: khuey, Assigned: fabrice)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #619487 +++

B2G still needs some love here.
This removes the memory_info_dumper.watch_fifo.directory OMT access.

I still see gfx.apitrace.enabled and gl.msaa-level.
Depends on: 985736
Duplicate of this bug: 985736
See Also: → 964636
Attachment #8387901 - Flags: review?(benjamin)
Attachment #8387901 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/be4f47078f6f
Assignee: nobody → fabrice
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
This bug still requires removing the #ifndef MOZ_B2G conditions in https://hg.mozilla.org/mozilla-central/rev/c50ed2757551 , right?
Flags: needinfo?(khuey)
Flags: needinfo?(fabrice)
(Or do the other 2 from comment 1 still need to be fixed first as well?)
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #6)
> (Or do the other 2 from comment 1 still need to be fixed first as well?)

I think so. I should have filed this one as a dependency instead of hijacking the whole bug :(
Flags: needinfo?(fabrice)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(khuey)
(In reply to [:fabrice] Fabrice Desré from comment #1)
> Created attachment 8387901 [details] [diff] [review]
> omt-pref-memdump.patch
> 
> This removes the memory_info_dumper.watch_fifo.directory OMT access.
> 
> I still see gfx.apitrace.enabled and gl.msaa-level.

These off main thread accesses were fixed, but b2g add 'dom.ipc.processPrelaunch.testMode' as off main thread access.

https://dxr.mozilla.org/mozilla-central/source/ipc/glue/MessageLink.cpp#148

The following is a tryserver result.
 https://treeherder.mozilla.org/logviewer.html#?job_id=11317921&repo=try
:cyu, can 'dom.ipc.processPrelaunch.testMode' be changed not to be accessed from off main thread? Bug 977359 add it.
Flags: needinfo?(cyu)
(In reply to Sotaro Ikeda [:sotaro] from comment #9)
> :cyu, can 'dom.ipc.processPrelaunch.testMode' be changed not to be accessed
> from off main thread? Bug 977359 add it.

Yes. I opened bug 1204455 for it.
Flags: needinfo?(cyu)
All the deps are fixed, can we just get rid of the ifdefs for B2G now, or is there more that needs to be done here?
Status: REOPENED → RESOLVED
Closed: 6 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.