Closed Bug 980428 Opened 6 years ago Closed 6 years ago

Add a DEBUG-only DataSourceSurface dtor to assert that the surface has not been left mapped

Categories

(Core :: Graphics, defect)

29 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

It seems I'm not to get my preference to make DataSourceSurface::Map use a RAII class as standard, so to ease my concerns about DataSourceSurfaces being left locked we should at least assert that that's not the case when they die.

This will depend on bug 980415 landing first in order to fix the locations in the code where surfaces are currently left locked.
Attached patch patchSplinter Review
Attachment #8386904 - Flags: review?(bas)
Depends on: 980436
Attachment #8386904 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/856705b0c63f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.