Closed Bug 980452 Opened 10 years ago Closed 10 years ago

Titlebar window controls button cutout is permanent (rendering glitch)

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30
Tracking Flags:
Tracking Status
firefox29 --- unaffected

People

(Reporter: Gijs, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [Australis:P1])

Attachments

(1 file, 1 obsolete file)

fix-region-to-clear v2
1.70 KB, patch
mconley
: feedback+
Details | Diff | Splinter Review 
STR:

1. Open a new Fx profile (if it matters, I'm in a win7 VM under VMWare...)
2. Make the window horizontally smaller
3. Make the window horizontally bigger again

ER:

Correct cutout for window controls

AR:

Cutout for window controls spans entire range that the buttons have been in while resizing the window

Matt, I'm guessing this is caused by your patch(es) from bug 940455. Any idea how/why, or should this be backed out?
Flags: needinfo?(matt.woodrow)
This reproduces on a 'normal' desktop machine as well.
Blocks: australis-cust
Keywords: regression
Whiteboard: [Australis:P1]
Assignee: nobody → matt.woodrow
Attached patch fix-region-to-clear (obsolete) — — Splinter Review 

        Attachment #8387135 -
        Flags: feedback?(mconley)
Flags: needinfo?(matt.woodrow)

    
    

    
  


  
Forgot that this function can recurse.

        Attachment #8387135 -
        Attachment is obsolete: true

        Attachment #8387135 -
        Flags: feedback?(mconley)

        Attachment #8387193 -
        Flags: feedback?(mconley)

    
    

    
  
Comment on attachment 8387193 [details] [diff] [review]
fix-region-to-clear v2

This is still no good. With this patch, when Fx starts up, at first there's a rectangular fog over the window buttons, but then after a second or so, the fog covers them over again.

        Attachment #8387193 -
        Flags: feedback?(mconley) → feedback-

    
    

    
  
That patch does fix a "tab cut off" drawing glitch for me on Windows 8, FWIW.

    
    

    
  
Making this a bit more findable...
Summary: Titlebar button cutout is permanent → Titlebar window controls button cutout is permanent (rendering glitch)

    
    

    
  
This should be fixed by the backout of bug 940455.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to Mike Conley (:mconley) from comment #4)
> Comment on attachment 8387193 [details] [diff] [review]
> fix-region-to-clear v2
> 
> This is still no good. With this patch, when Fx starts up, at first there's
> a rectangular fog over the window buttons, but then after a second or so,
> the fog covers them over again.

I can't reproduce this :(

What OS version and about:support graphics settings do you have?

It seems just fine for me, except the cleared out area lags behind a bit while resizing. I assume this was always the case though, since I can't see how my changes would affect that.

Thanks for backing the other patch out though.
Flags: needinfo?(mconley)
Target Milestone: --- → mozilla30

    
    

    
  
Comment on attachment 8387193 [details] [diff] [review]
fix-region-to-clear v2

Reversing my original feedback, because I retested this, and it looks fine. I have no idea why it wasn't working for me on Friday. Work-week exhaustion, maybe. :/

        Attachment #8387193 -
        Flags: feedback- → feedback+
Flags: needinfo?(mconley)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: