Closed Bug 980454 Opened 10 years ago Closed 10 years ago

will-change: transform should be a 'containing block'

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(3 files)

containing_block.html testcase
285 bytes, text/html
Details
reftest
2.74 KB, patch
roc
: review+
Details | Diff | Splinter Review
reftest, r=roc
1.97 KB, patch
BenWa
: review+
Details | Diff | Splinter Review 
> ajuma: the issue is that when an element has a transform on it, its fixed pos descendants get positioned wrt it instead of the viewport. so someone from microsfot had asked on www-style to make will-change:transform behave the same way, and then that got added to the spec

We need to implement this behavior before we turn it on for web content.
bug 976365 conveniently just cleaned up the relevant code, but we still need to make a change to get this behavior.
Looks like we support this fine. I'm going to turn this into a bug to add a reftest.
Attached patch reftest — — Splinter Review 
Assignee: nobody → bgirard
Status: NEW → ASSIGNED

        Attachment #8400351 -
        Flags: review?(roc)

    
    

    
  
Comment on attachment 8400351 [details] [diff] [review]
reftest

This test doesn't use the 'will-change' property anywhere, so it clearly doesn't test this bug.

        Attachment #8400351 -
        Flags: review?(roc) → review-

    
    

    
  
Comment on attachment 8400351 [details] [diff] [review]
reftest

Er, never mind.  I'm still curious what makes it work.

        Attachment #8400351 -
        Flags: review- → review?(roc)

    
    

    
  
Oh, it's inside the HasTransform check.

    
    

    
  
(Though I'm concerned that you're adding a willchange-containing-block-ref.html file that you're not using.  I should probably shut up now before I embarrass myself further, though.)

    
    

    
  
Comment on attachment 8400351 [details] [diff] [review]
reftest

Review of attachment 8400351 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that

::: layout/reftests/transform-3d/willchange-containing-block-ref.html
@@ +1,3 @@
> +<!DOCTYPE HTML>
> +<html>
> +<body>

David's absolutely right, you should not be adding this file you're not using.

        Attachment #8400351 -
        Flags: review?(roc) → review+

    
    

    
  
Comment on attachment 8400351 [details] [diff] [review]
reftest

Review of attachment 8400351 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/transform-3d/willchange-containing-block-ref.html
@@ +1,3 @@
> +<!DOCTYPE HTML>
> +<html>
> +<body>

Opps, yes I decided to use the query string. This should of been removed.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/119b076c27e8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: