980517 - about:blank leaks in tests run locally

Status: RESOLVED DUPLICATE of bug 894806

(Firefox :: General, defect)

Description

[Shane Caraveo (:mixedpuppy)]

I initially ran into these leaks via try on a patch for bug 894806, you can see the try here: https://tbpl.mozilla.org/?tree=Try&rev=ba11441a5071  

I built a clean pull, and can easily reproduce the leaks 100% of the time without the patch on osx 10.9.2 and a win7 vm.  @smaug was also able to reproduce when running the test locally.  I don't see other pushes on tbpl producing these leaks.  I'm focusing on one leak in particular to see if there is something general causing this.

to repro either run all browser tests, or you can simply run this one:

./mach mochitest-browser browser/base/content/test/general/browser_bug477014.js


The only other indication of a problem I've seen (sporadically) shows in this test run:

 0:09.27 INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug477014.js | finished in 458ms
 0:09.27 TEST-INFO | checking window state
 0:09.60 TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug477014.js | Console message: [JavaScript Error: "A promise chain failed to handle a rejection.
 0:09.60
 0:09.60 Date: Thu Mar 06 2014 11:23:56 GMT-0800 (PST)
 0:09.60 Full Message:
 0:09.60 Full Stack: JS frame :: chrome://browser/content/browser.js :: gBrowserInit._delayedStartup/< :: line 10682
 0:09.60 JS frame :: resource://gre/modules/Promise.jsm :: Handler.prototype.process :: line 774
 0:09.60 JS frame :: resource://gre/modules/Promise.jsm :: this.PromiseWalker.walkerLoop :: line 653
 0:09.60 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0" {file: "chrome://browser/content/browser.js" line: 10682 column: 0 source: "10682"}]
 0:10.99 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug477014.js | leaked until shutdown [nsGlobalWindow #18 about:blank]


line 10682 is the setTimeout in delayed startup that calls BrowserChromeTest.markAsReady:

    SessionStore.promiseInitialized.then(() => {
      // Enable the Restore Last Session command if needed
      RestoreLastSessionObserver.init();

      TabView.init();

      setTimeout(function () { BrowserChromeTest.markAsReady(); }, 0);
    });
    this.delayedStartupFinished = true;

    Services.obs.notifyObservers(window, "browser-delayed-startup-finished", "");
    TelemetryTimestamps.add("delayedStartupFinished");
  },

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

I couldn't figure out what's causing the leaks described here but I attached a patch to bug 894806 that fixes at least some of the leaks there.

Comment 2

[Shane Caraveo (:mixedpuppy)]

patch in bug 894806 fixed the issue for me.