980521 - [AccessFu] Introduce content text tests

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

We need to test the move by granularity bits, along with cursor control, and braille routing keys.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Introduce content text tests.

Moved some things around...

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 8387061 [details] [diff] [review]
Introduce content text tests.

Very cool! One nit: recieved -> received.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8387061 [details] [diff] [review]
Introduce content text tests.

Review of attachment 8387061 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, some comments inline. Also got his test failures:
1:18.38 12 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got many option check button, expected many option not checked check button
 1:18.38 16 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got checked, expected Home button
 1:18.38 17 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got wow heading level 1, expected many option checked check button such app
 1:18.38 18 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got Home button, expected unchecked
 1:18.38 19 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got many option check button such app, expected Phone status bar
 1:18.38 20 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got wow heading level 1, expected wow heading level 1 such app
 1:18.38 24 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got Phone status bar Traversal Rule test document, expected many option not checked check button
 1:18.38 28 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got Phone status bar, expected Phone status bar Traversal Rule test document
 1:18.38 68 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | {"0":{"eventType":"expected 131072 got 8192","toIndex":"expected 37 got 36"}}
 1:18.38 69 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | {"0":{"fromIndex":"expected 37 got 36","toIndex":"expected 38 got 37"}}
 1:18.38 70 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | {"0":{"eventType":"expected 131072 got 8192","fromIndex":"expected 38 got 37","toIndex":"expected 59 got 37"}}
 1:18.38 71 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | {"0":{"fromIndex":"expected 53 got 37","toIndex":"expected 59 got 38"}}
 1:18.38 194 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for label1 (output: check button, Orange) == (expected: not checked check button, Orange) -     Structures begin differing at:
 1:18.38 198 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for label1 (output: Orange, check button) == (expected: Orange, not checked check button) -     Structures begin differing at:
 1:18.38 202 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for form1 (output: label, check button, Orange, Orange, check button, Blue, label, Blue) == (expected: label, not checked check button, Orange, Orange, not checked check button, Blue, label, Blue) -     Structures begin differing at:
 1:18.38 206 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for form1 (output: Orange, check button, Orange, label, Blue, check button, Blue, label) == (expected: Orange, not checked check button, Orange, label, Blue, not checked check button, Blue, label) -     Structures begin differing at:
 1:18.38 214 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for input2 (output: check button, Blue) == (expected: not checked check button, Blue) -     Structures begin differing at:
 1:18.38 220 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for input2 (output: Blue, check button) == (expected: Blue, not checked check button) -     Structures begin differing at:
 1:18.38 226 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for input1 (output: check button, Orange) == (expected: not checked check button, Orange) -     Structures begin differing at:
 1:18.38 232 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for input1 (output: Orange, check button) == (expected: Orange, not checked check button) -     Structures begin differing at:
 1:18.38 266 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for input5 (output: check button, Boring label) == (expected: checked check button, Boring label) -     Structures begin differing at:
 1:18.38 272 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for input5 (output: Boring label, check button) == (expected: Boring label, checked check button) -     Structures begin differing at:
 1:18.38 278 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for radio_unselected (output: radio button, any old radio button) == (expected: not checked radio button, any old radio button) -     Structures begin differing at:
 1:18.38 284 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for radio_unselected (output: any old radio button, radio button) == (expected: any old radio button, not checked radio button) -     Structures begin differing at:
 1:18.38 290 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for radio_selected (output: radio button, a unique radio button) == (expected: checked radio button, a unique radio button) -     Structures begin differing at:
 1:18.38 296 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for radio_selected (output: a unique radio button, radio button) == (expected: a unique radio button, checked radio button) -     Structures begin differing at:
 1:18.38 302 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for togglebutton_notpressed (output: toggle button, I ain't pressed) == (expected: not checked toggle button, I ain't pressed) -     Structures begin differing at:
 1:18.38 306 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for togglebutton_notpressed (output: I ain't pressed, toggle button) == (expected: I ain't pressed, not checked toggle button) -     Structures begin differing at:
 1:18.38 310 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for togglebutton_pressed (output: toggle button, I am pressed!) == (expected: not checked toggle button, I am pressed!) -     Structures begin differing at:
 1:18.38 314 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_output.html | Context output is correct for togglebutton_pressed (output: I am pressed!, toggle button) == (expected: I am pressed!, not checked toggle button) -     Structures begin differing at:

::: accessible/src/jsat/Presentation.jsm
@@ +574,5 @@
> +      'b2g': [VisualPresenter, SpeechPresenter, HapticPresenter],
> +      'browser': [VisualPresenter, SpeechPresenter, HapticPresenter,
> +                  AndroidPresenter]
> +    };
> +    this.presenters = [new p() for (p of presenterMap[Utils.MozBuildApp])];

nit: since it's a constructor lets have |p| capitalized.

::: accessible/tests/mochitest/jsat/doc_content_text.html
@@ +4,5 @@
> +    <title>Text content test document</title>
> +    <meta charset="utf-8" />
> +  </head>
> +  <body>
> +  <p>These are my awards, Mother. From Army.

:)

::: accessible/tests/mochitest/jsat/jsatcommon.js
@@ +250,5 @@
> +      }
> +
> +      var android = this.extractAndroid(aMessage.json);
> +      if (android && expected.android !== undefined) {
> +        var delta = {};

this part is a little confusing, maybe we can do something like this:
// this.lazyCompare(android, expected.android) returns [matches, delta]
var test = SimpleTest[expected.android_checkFunc] || ok;
test.apply(SimpleTest, this.lazyCompare(android, expected.android));

@@ +260,5 @@
>  
>      this.pump();
>    },
>  
> +  lazyCompare: function lazyCompare(aRecieved, aExpected, aDeltaOut) {

If you like the comment above this could be
lazyCompare: function lazyCompare(aRecieved, aExpected) {
  var delta = [];
  ...
  return [matches, delta]
}

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Introduce content text tests.

All good ideas.. and spelling!

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Looks good, still god tome failures:

 1:17.34 14 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got checked, expected Home button
 1:17.34 15 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got wow heading level 1, expected many option checked check button such app
 1:17.34 16 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got Home button, expected unchecked
 1:17.34 17 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got many option checked check button such app, expected wow heading level 1
 1:17.34 18 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got wow heading level 1, expected Phone status bar
 1:17.34 19 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got many option checked check button, expected wow heading level 1 such app
 1:17.34 20 INFO TEST-UNEXPECTED-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - Home button should equal Home button
 1:17.34 25 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_integration.html | undefined - got many option checked check button, expected many option not checked check button
 1:17.34 65 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | 0 [ eventType [ expected 131072 got 8192 ] toIndex [ expected 37 got 36 ] ]
 1:17.34 66 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | 0 [ fromIndex [ expected 37 got 36 ] toIndex [ expected 38 got 37 ] ]
 1:17.34 67 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | 0 [ eventType [ expected 131072 got 8192 ] fromIndex [ expected 38 got 37 ] toIndex [ expected 59 got 37 ] ]
 1:17.34 68 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_content_text.html | 0 [ fromIndex [ expected 53 got 37 ] toIndex [ expected 59 got 38 ] ]

Comment 6

[Eitan Isaacson [:eeejay]]

wfm, starting a try build:
https://tbpl.mozilla.org/?tree=Try&rev=2b0ea9d1d242

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Introduce content text tests.

Much greener!
https://tbpl.mozilla.org/?tree=Try&rev=672228b41e7b

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Hey Eitan, would you be able to repost the patch so I can apply it to run the tests? Thanks!

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Introduce content text tests.

Comment 10

[Eitan Isaacson [:eeejay]]

Reposted!

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8393087 [details] [diff] [review]
Introduce content text tests.

Review of attachment 8393087 [details] [diff] [review]:
-----------------------------------------------------------------

Works great!

Comment 12

[Eitan Isaacson [:eeejay]]

Triple checking: https://tbpl.mozilla.org/?tree=Try&rev=f9d6e486b877

Comment 13

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c50c2fc1ff1

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c50c2fc1ff1