Closed Bug 980524 Opened 9 years ago Closed 9 years ago

Visual Studio 2013: TEST-UNEXPECTED-FAIL | /tests/content/media/webaudio/test/test_mediaDecoding.html | Expected at most 3 bytes difference, found 5 bytes

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file)

Increase fuzzTolerance
865 bytes, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
With Visual Studio 2013 Update 2 CTP2, ting-48k-1ch.ogg [1] has a resampling error of 5 bytes, which exceeds the fuzzTolerance of 3 bytes. Occurs with both opt and PGO builds. I imagine it's a result of slightly different floating-point codegen.

[1] https://hg.mozilla.org/mozilla-central/file/02506bdd5bd8/content/media/webaudio/test/test_mediaDecoding.html#l141
Bumping the tolerance from 3 to 5 is fine.
(In reply to comment #1)
> Bumping the tolerance from 3 to 5 is fine.

Yeah, these values basically come form me pushing this test to try with some instrumentation to count how many errors we have and adjusting the values!
Assignee: nobody → dmajor

        Attachment #8387800 -
        Flags: review?(ehsan)

    
  

        Attachment #8387800 -
        Flags: review?(ehsan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/eab9004f97e7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

          You need to log in
          before you can comment on or make changes to this bug.