980526 - Setting a breakpoint calls findScripts too often

Status: RESOLVED DUPLICATE of bug 1096739

(DevTools :: Debugger, defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

dbg.findScripts is SSSSSSSSSLLLLLLLLLLLOOOOOOOOOOOOWWWWWWWWWWW!!!

Even if you have a query parameter.

We do it at least twice, maybe even more; I haven't counted.

We could either rework some logic and avoid calling it as much, or we could keep a cache of scripts and update it as onNewScript is fired. The latter might be a bit trickier (maybe not, who knows) but would also allow us to do some interesting indexing that isn't done on the platform level (at least as of yet) which would give us even better speedups when we are using a query parameter.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Basically the same check in two different places:

http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/script.js#1339
http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/script.js#1426

Comment 2

[Eddy Bruel [:ejpbruel]]

Hey Nick. This seems like low hanging fruit, and something you could easily fix. Any way I could convince you to write a patch for this? If you're too busy for that, perhaps this would be a good mentored bug?

Comment 3

[Eddy Bruel [:ejpbruel]]

This will probably be fixed as part of my refactor of the breakpoint code.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This was fixed by bug 1096739.