Closed Bug 980530 Opened 6 years ago Closed 6 years ago

remote-browser.xml shouldn't send IPC messages in constructor

Categories

(Firefox :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch browser-initSplinter Review
When you set the pref to restore tabs at startup, there seems to be some session restore code that causes the remote-browser.xml XBL binding to be installed earlier than usual. That causes the constructor to run before the message manager has been fully initialized. We end up getting an NS_NOT_INITIALIZED error here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/remote-browser.xml#198

I talked to Olli about this and it seems like the easiest fix is for the browser-child.js script to request the information it needs.
Attachment #8387076 - Flags: review?(wmccloskey)
Comment on attachment 8387076 [details] [diff] [review]
browser-init

Oops.
Attachment #8387076 - Flags: review?(wmccloskey) → review?(felipc)
Comment on attachment 8387076 [details] [diff] [review]
browser-init

Review of attachment 8387076 [details] [diff] [review]:
-----------------------------------------------------------------

Just add a comment in the remote-browser constructor about this so we don't later add messages again
Attachment #8387076 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/f05bca38aa4d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.