980530 - remote-browser.xml shouldn't send IPC messages in constructor

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: browser-init

When you set the pref to restore tabs at startup, there seems to be some session restore code that causes the remote-browser.xml XBL binding to be installed earlier than usual. That causes the constructor to run before the message manager has been fully initialized. We end up getting an NS_NOT_INITIALIZED error here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/remote-browser.xml#198

I talked to Olli about this and it seems like the easiest fix is for the browser-child.js script to request the information it needs.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8387076 [details] [diff] [review]
browser-init

Oops.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8387076 [details] [diff] [review]
browser-init

Review of attachment 8387076 [details] [diff] [review]:
-----------------------------------------------------------------

Just add a comment in the remote-browser constructor about this so we don't later add messages again

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f05bca38aa4d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f05bca38aa4d