980581 - Previous video clip title remains when a new video clip is selected

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Diego Wilson [:diego]]

It remains for for less than a second, but it's still noticeable.

Comment 1

[Diego Wilson [:diego]]

Attachment: Screen recording

This issue is reproducible on v1.4 in both QRD 8926 and a 7x27A (ICS) device.

Comment 2

[Diego Wilson [:diego]]

Hi John,

Do you agree this is a bug? Maybe the video playback title should be immediately wiped when a new clip is selected.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Diego,

Yes, it's a bug. It is caused by that the code [1] is executed before [2]. The current version may be move the code [1] to the callback function of setVideoUrl[3].

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L904-L906
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L940-L949
[3] https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L928

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

There is another candidate that move the code [2] before [1] which shows title immediately but black screen at the video element.

In contrast, if we move the [1] to [3], the screen may wait few milliseconds after user taps the thumbnail. After that, the title and video will be ready at the same time.

Basically, this is a small defect of UI. The tablet is also affected.

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #3)
> Hi Diego,
> 
> Yes, it's a bug. It is caused by that the code [1] is executed before [2].
> The current version may be move the code [1] to the callback function of
> setVideoUrl[3].
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L904-
> L906
> [2]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L940-
> L949
> [3]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L928

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Russ,

Since you are working on video app recently, I hope you may find this bug. It's easy and worth to fix it, but not a blocker.

Comment 6

[Russ Nicoletti [:russn]]

Ok, I will take a look.

Comment 7

[Russ Nicoletti [:russn]]

Attachment: Pull request: https://github.com/mozilla-b2g/gaia/pull/17260

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8392653 [details] [review]
Pull request: https://github.com/mozilla-b2g/gaia/pull/17260

Thanks for this patch. It's a nice patch.

Comment 9

[Diego Wilson [:diego]]

The patch works for me. Thanks Russ!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please post a link to the revision when you merge the PR.
Master: https://github.com/mozilla-b2g/gaia/commit/5bb95e384f8923963c1990a55cb297996a0f2645

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v1.4: a6247c0f2389127d3d244bf4bfc9793ea4517d75

Comment 12

[Russ Nicoletti [:russn]]

Regarding comment #10, I will post the link for future merges. Thanks for letting me know.

Comment 13

[Yeojin Chung [:YeojinC]]

New test case needs to be added. There is no existing test case.

Comment 14

[KTucker [:KTucker][Inactive 3/4/2016]]

New moztrap test case written:

https://moztrap.mozilla.org/manage/case/14200/