Closed
Bug 980586
Opened 10 years ago
Closed 10 years ago
Remove old e10s prompt stuff
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file, 1 obsolete file)
|
32.07 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Olli wrote a bunch of code back in the day to implement prompts and alerts for e10s. Unfortunately, since that time, the entire system got overhauled and his code got outdated. Now, with bug 899648, we're reimplementing it entirely (in JS this time), meaning that we can get rid of the old code.
|
Assignee | |
Comment 1•10 years ago
|
||
smaug, I'm sorry to do this to you, but would you mind stamping the removal of this code?
Attachment #8387142 -
Flags: review?(bugs)
|
||
Comment 2•10 years ago
|
||
no worry. I finally managed to clear my review queue. I'll review this tomorrow.
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8387142 [details] [diff] [review] Patch I think you could also remove nsIDialogCreator.idl. That was added for this stuff.
Attachment #8387142 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8387142 -
Attachment is obsolete: true
Attachment #8387871 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e5d9cc36cd4
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6e5d9cc36cd4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e091138b5cb follow-up: Remove PContentDialog.ipdl
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5e091138b5cb
You need to log in
before you can comment on or make changes to this bug.
Description
•