980623 - Update gdb pretty printers for new location of clasp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Several people are reporting that object printing is busted.

<terrence> is anyone else getting "Python Exception <class 'gdb.error'> Cannot take address of method clasp.:" in gdb at the moment?

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Update gdb pretty printers for new location of clasp

Looks like the clasp moved from the baseshape to the type.

Also, the tests were failing. I snuck in a fix for that too.

And there's now a Python commit hook that does style checks. It told me to raise an exception differently.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8387189 [details] [diff] [review]
Update gdb pretty printers for new location of clasp

Review of attachment 8387189 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review. Thanks, Steve.

Comment 3

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44a165ab1670

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44a165ab1670