Closed Bug 980684 Opened 6 years ago Closed 6 years ago

Actually use IOSurfaces on Mac

Categories

(Core :: Graphics: Layers, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now, we appear to be accidentally relying on sharegroups, and not guaranteeing resolve properly, to boot.
Attached patch mac-io-surf (obsolete) — Splinter Review
Attachment #8387272 - Flags: review?(snorp)
Comment on attachment 8387272 [details] [diff] [review]
mac-io-surf

Review of attachment 8387272 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.h
@@ +2694,5 @@
>      ScopedDeletePtr<GLBlitTextureImageHelper> mBlitTextureImageHelper;
>      ScopedDeletePtr<GLReadTexImageHelper> mReadTexImageHelper;
>  
>  public:
> +    ScopedDeletePtr<GLBlitHelper> mBlitHelper;

why public? there's already an accessor for this
Attachment #8387272 - Flags: review?(snorp) → review+
Attached patch mac-io-surfSplinter Review
Fixed an issue with binding a rect-type texture to an FB as a regular texture2d.
Attachment #8387272 - Attachment is obsolete: true
Attachment #8388010 - Flags: review?(snorp)
Attachment #8388010 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/7d62c468b48b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.