Windows debug build with purplexpcom fails

RESOLVED FIXED in 1.6

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

trunk
x86
Windows 8.1

Details

Attachments

(1 attachment, 2 obsolete attachments)

Currently debug builds with purplexpcom fail since purple.def can't be built: http://hg.mozilla.org/users/florian_queze.net/purple/file/6b77268d791c/libpurple/Makefile.in#l69

Specially EXPORTS_libpurple doesn't exist any longer.
Posted patch Dirty hack (obsolete) — Splinter Review
I am by no means proud of what this patch does, but it builds!

Pretty much we take the moz.build file, pull out all the .h files in it, kill any commented out lines (^#) and then cut out the part between single quotes. All pretty straightforward, right?
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #8393888 - Flags: review?(florian)
Posted patch Dirty hack v2 (obsolete) — Splinter Review
Looks like I uploaded the wrong version of this, sorry.
Attachment #8393888 - Attachment is obsolete: true
Attachment #8393888 - Flags: review?(florian)
Attachment #8393890 - Flags: review?(florian)
Comment on attachment 8393890 [details] [diff] [review]
Dirty hack v2

Review of attachment 8393890 [details] [diff] [review]:
-----------------------------------------------------------------

::: libpurple/Makefile.in
@@ +70,5 @@
> +# not accessible to make anymore. Luckily all the .h files in the moz.build file
> +# are part of EXPORTS_libpurple.
> +EXPORTS_libpurple := $(shell egrep '.+\.h' '$(srcdir)/moz.build' |egrep -v '^\#' |cut -d "'" -f 2)
> +
> +purple.def: ../libraries/glib/glib.def $(GLOBAL_DEPS)

Why is purple.def no longer depending on $(EXPORTS_libpurple)? I think you do want to remake purple.def if any of these .h files is changed.
Posted patch Dirty hack v3Splinter Review
I misunderstood what those commands were there for. Sorry about that.
Attachment #8393890 - Attachment is obsolete: true
Attachment #8393890 - Flags: review?(florian)
Attachment #8394070 - Flags: review?(florian)
Comment on attachment 8394070 [details] [diff] [review]
Dirty hack v3

Review of attachment 8394070 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this! :-)
Attachment #8394070 - Flags: review?(florian) → review+
http://hg.mozilla.org/users/florian_queze.net/purple/rev/ad17398f7131
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.