Closed Bug 980783 Opened 6 years ago Closed 6 years ago

Make scale-1.svg use MozReftestInvalidate

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dholbert, Assigned: dholbert)

References

()

Details

Attachments

(1 file)

Spinning this off of bug 978911, to make scale-1.svg use MozReftestInvalidate to be more deterministic.
Attached patch fix v1Splinter Review
Here's the patch.

This makes the reftest.list fuzzy/random annotations more strict, too.

Here's a Try run with no annotations at all (more optimistic than the attached patch):
 https://tbpl.mozilla.org/?tree=Try&rev=81a1d462c374

That Try run shows that we still have some fuzziness. The fuzziest jobs completed so far are the Win7 jobs, which have "max difference: 12, number of differing pixels: 27". Hence, the fuzzy(12, 27) in this patch that I'm attaching here.
Attachment #8387385 - Flags: review?(jwatt)
Comment on attachment 8387385 [details] [diff] [review]
fix v1

Yes, please! Maybe the fuzzy(12,27) should have a bug comment appended, but since of all the bugs we're likely never to get to that I'll leave it up to you whether you file one and add that comment.
Attachment #8387385 - Flags: review?(jwatt) → review+
I filed bug 981004 to track the fuzziness, and noted it in the manifest.

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/d54517381f96
URL:
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/d54517381f96
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.