Closed Bug 980786 Opened 6 years ago Closed 5 years ago

Shader Editor should not be a valid tool in browser toolbox

Categories

(DevTools Graveyard :: WebGL Shader Editor, defect)

defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: past, Assigned: jsantell)

Details

Attachments

(1 file)

Reproduced in both Linux and OS X. STR:

1. Open the Browser Toolbox.
2. Go to the options panel and enable the shader editor.
3. Click on the shader editor tab:

*************************
A coding exception was thrown in a Promise resolution callback.

Full message: TypeError: this.conn.allocID is not a function
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full stack: Pool<.manage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:689:7
exports.WebGLFront<.initialize@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webgl.js:347:5
constructor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:145:23
ShaderEditorPanel.prototype.open/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shadereditor/panel.js:38:9
Handler.prototype.process@resource://gre/modules/Promise.jsm:774:11
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:653:7

*************************
Probably same as bug 988928
The remote debugging error is tracked in bug 988928, but this tool shouldn't even be in the browser toolbox anyway.
Summary: Opening the shader editor in a browser toolbox results in TypeError: this.conn.allocID is not a function → Shader Editor should not be a valid tool in browser toolbox
https://treeherder.mozilla.org/#/jobs?repo=try&revision=249641b765d3
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8565791 - Flags: review?(vporof)
Comment on attachment 8565791 [details] [diff] [review]
980786-disable-shader-chrome.patch

Review of attachment 8565791 [details] [diff] [review]:
-----------------------------------------------------------------

Same thing goes for the canvas debugger right?
Attachment #8565791 - Flags: review?(vporof) → review+
canvas debugger is already disabled in chrome
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bf0c74950c9c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.