Closed Bug 980816 Opened 10 years ago Closed 4 years ago

[MediaEncoder] TrackEncoder should filter out the MediaSegment with zero duration?

Categories

(Core :: Audio/Video: Recording, defect, P3)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bechen, Unassigned)

References

(Blocks 1 open bug)

Details

http://dxr.mozilla.org/mozilla-central/source/content/media/TrackUnionStream.h?from=trackunionstream&case=true#176

TrackEncoder will receive MediaSegment with zero duration because the segment only carries the TRACK_EVENT_CREATED event. We should filter out this kind of segments instead pending it to vp8/omx encoder?
We handle track end notification in VideoTrackEncoder::NotifyQueuedTrackChanges
184   if (aTrackEvents == MediaStreamListener::TRACK_EVENT_ENDED) {
185     LOG("[VideoTrackEncoder]: Receive TRACK_EVENT_ENDED .");
186     NotifyEndOfStream();
187   }

For me, it makes sense to handle MediaStreamListener::TRACK_EVENT_CREATED in that function as well
Rank: 27
Priority: -- → P2
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3

Overtaken by events.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.