980831 - [B2G] [tarako] add quirk "ro.moz.ril.[n].network_types" to indicate supported network types

Status: RESOLVED DUPLICATE of bug 953439

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We need hardware information of the supported network types.

Please add "ro.moz.ril.[n].network_types" in bask.mk and assign correct values to the quirk. And [n] is the subscription id.

For example:
(1) Fugu (Multi-SIM device),
    ro.moz.ril.0.network_types = gsm,wcdma
    ro.moz.ril.1.network_types = gsm

(2) Unagi (Single-sim device),
    ro.moz.ril.0.network_types = gsm,wcdma

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Sam, could you please help this?

Comment 2

[sam.hua]

OKay

Comment 3

[sam.hua]

it is checked in now.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

1.3T+ as this needs to be fixed for DSDS on Tarako

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

to Sam

Shawn, can you please confirm this is now working? thanks

Comment 6

[shawn ku [:sku]]

Hi Sam:
 Could you please help check if below two properties are set in tarako?
I cannot see it in my local trial.

BTW, after set it manually, UI shows correctly.

ro.moz.ril.0.network_types=gsm
ro.moz.ril.1.network_types=gsm

Thanks!!
Shawn

Comment 7

[sam.hua]

sorry,it is under review process.

Comment 8

[sam.hua]

I just confirmed that it has been checked in.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I did :  adb shell getprop ro.moz.ril.0.network_types

and did not see any results with one SIM in the device.  Is that suppose to happen?

Comment 10

[sam.hua]

yes, in the device/sprd/sp6821a_gonk/base.mk.

I checked the last build of server
adb shell getprop | grep network
[ro.moz.ril.0.network_types]: [gsm]
[ro.moz.ril.1.network_types]: [gsm]