980834 - When Soundcloud fails to load you cannot play make

Status: RESOLVED FIXED

(Webmaker Graveyard :: General, defect)

Description

[Laura Hilliger [:epilepticrabbit]]

I'm curious as to why this popcorn make looks like it loads but isn't really doing so. It shows what I'm guessing is the first frame, but you can't play or remix or full screen or anything else. I was just wondering if this is fixable for old makes?

http://popcorn.webmadecontent.org/apz

Comment 1

[Jon Buckley [:jbuck]]

I think it's because http://soundcloud.com/kimlehere/rocky-gonna-fly-now doesn't exist anymore. If you replace that soundcloud file with a different one, maybe it'll work again?

Having a soundcloud file 404 and have the whole thing break is kinda janky. Lets fix that!

Comment 2

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn-js/pull/389

Fxing it so if it errors it lets you play but the clip won't work.

This particular case looks to be the user changed their name.

Comment 3

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/486

Comment 4

[Jon Buckley [:jbuck]]

Comment on attachment 8387696 [details] [review]
https://github.com/mozilla/popcorn-js/pull/389

This fix looks good, but https://github.com/mozilla/popcorn-js/commit/373097d2ba835b60abfa962ea5f157193a77dab4 changed things for the worse...

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 8387696 [details] [review]
https://github.com/mozilla/popcorn-js/pull/389

Updated

Comment 6

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/06a24448cf51e2793a972fa9c14cdb51e8327259
Staged: https://github.com/mozilla/popcorn-js/commit/a7e0d2c27f2b2bb1178dce482fc6e6d5b14b2187
Staged: https://github.com/mozilla/popcorn-js/commit/c265a58b0355a65b76ac59799026523afa8ee485

Comment 7

[Scott [:thecount] Downe]

Looks like we don't listen for error events in projects before we used the null wrapper.

So maybe we swap out the busted player for a null wrapper if it fails.

Comment 8

[Scott [:thecount] Downe]

Yeah, we're not going to make this work for old projects, but for new ones we now properly fall back.