980917 - Add-ons Manager behavior is not consistent

Status: RESOLVED DUPLICATE of bug 801322

(Toolkit :: Add-ons Manager, defect)

Description

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:30.0) Gecko/20100101 Firefox/30.0

STR:
1. In Add-ons Manager, uncheck Update Add-ons Automatically option.
2. Install older version of Adblock Plus (eg: version 2.4 from https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/versions/)
3. Check for updates.
4. Remove addon from Add-ons Manager/Extensions, go to Available Updates and click on Install updates button.
5. Click on Enable this add-on and restart Firefox when requested. 

Expected results: The add-on is present in Add-ons Manager/Extensions.

Actual results: The add-on is not present in Add-ons Manager/Extensions.

Notes:
1. This is very confusing for the user since is prompted to restart Firefox in order to enable the add-on.
2. At step 4, In Browser Console I get:
"WARN addons.xpi: Failed to install C:\Users\ALEXAN~1.LUC\AppData\Local\Temp\tmp-rhf.xpi from https://addons.cdn.mozilla.net/storage/public-staging/1865/adblock_plus-2.5.1-sm+tb+an+fx.xpi: 
Error: Unknown add-on ID {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} (resource://gre/modules/XPIProvider.jsm:7221)"

3. When I re-install Adblock Plus 2.4, in Browser Console I get (although the add-on was successfully installed): 
"WARN addons.xpi: Failed to remove temporary file C:\Users\ALEXAN~1.LUC\AppData\Local\Temp\tmp-s1a.xpi for addon https://addons.mozilla.org/firefox/downloads/file/230225/adblock_plus-2.4-tb+fx+an+sm.xpi?src=version-history: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/XPIProvider.jsm :: AI_removeTemporaryFile :: line 4929"  data: no]"

4. Reproducible with Firefox 28 beta 8 (Build ID: 20140303165517), latest Nightly (Build ID: 20140307030202) and Aurora (Build ID: 20140307004002) on Windows 7 64bit, Mac OS X 10.9.1 and Ubuntu 13.10 64bit.
5. Not reproducible with Firefox 4.0 - I think it may be related with the required restart after add-on installation. I'll investigate further.
6. On Mac OS X 10.9.1 and Ubuntu 13.10 64bit, the error from Notes 2 is not displayed.

Comment 1

[:Irving Reid (No longer working on Firefox)]

I think the add-on should be removed from the list of available updates if it is uninstalled after the update check (though somebody should also look into the 'failed to remove temporary file' error).

We might also need to be careful about differences in behaviour between restartless and restartful add-ons.