980984 - Alert the user of an incoming from the system app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Etienne Segonzac (:etienne)]

Bug 979419 and bug 979426 are not going to cut it :/
Event when lazy loading everything getting the ringtone from the mozSettings DB takes a loooong time while the phone is so buzzy.

Good news is, this patch is less risky and insta-backaoutable (adding a new file).

And it's working *very* well, even on the tarako I hear the phone ringing *before* the first ring on the SIP client side. Then it takes a few seconds for the call screen to show up.

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

r? Alive for the system part (you'll like it, it's small and System2 compliant :))
r? Rik for the dialer part (only removals) and a more than welcome feedback on the system part

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8387749 [details] [review]
Gaia PR

r+ with nit

Comment 3

[Anthony Ricaud (:rik)]

Comment on attachment 8387749 [details] [review]
Gaia PR

Looks very good. A few questions/comments on the PR but good to go.

Comment 4

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/88677ea30dff41d6dc404ab95285d318accdd738

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Reverted for Gaia unit test failures.
https://github.com/mozilla-b2g/gaia/commit/3005269d4dcabcc7d27eaf72bda44a969873af8c

https://tbpl.mozilla.org/php/getParsedLog.php?id=35943863&tree=B2g-Inbound

Comment 6

[Etienne Segonzac (:etienne)]

Was able to reproduce locally, this should be better.
https://github.com/mozilla-b2g/gaia/commit/5aa7d6e424c46c2a9761ec85a016f39de3105d71

Comment 7

[James Ho]

Is there still a few seconds delay before the screen shows up after the phone rings?

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

base on initial testing, ringtone does ring quickly but screen still show up after a couple rings

Comment 9

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

If music app is at foreground, its audio channel that used to play music won't be suspended when ringtone starts in system app. So the music and ringtone are both playing before music is put to background.

Comment 10

[Kevin Grandon :kgrandon]

Attachment: gaia follow-up, remove unused mock.

I've landed a simple follow-up for this here: https://github.com/mozilla-b2g/gaia/commit/5d26761bd64da1839f9afda585ddb974244056fd (r=me)

Comment 11

[[:fabrice] Fabrice Desré]

(In reply to Patrick Wang (Chih-Kai Wang) (:kk1fff) from comment #9)
> If music app is at foreground, its audio channel that used to play music
> won't be suspended when ringtone starts in system app. So the music and
> ringtone are both playing before music is put to background.

Did you file a followup? (I can't find one but that may be me!)

Comment 12

[Etienne Segonzac (:etienne)]

ni answered in Comment 8.

Comment 13

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/7f9d0b0c3717ffe1de33479530c0151ee7201ee8

Comment 14

[Jesse]

After the commit, call screen shows about 5-10 seconds after the ringer plays. Should we also open call screen in system app like call ringer?

Comment 15

[Etienne Segonzac (:etienne)]

(In reply to Jesse from comment #14)
> After the commit, call screen shows about 5-10 seconds after the ringer
> plays. Should we also open call screen in system app like call ringer?

Technically we _could_.
But I don't see it happening in the 1.3t time frame...
The call screen talks with the dialer app a lot, so making it part of system app will require a rewrite of:
* the insertion in the call log history
* the bluetooth support
* the headset support

Comment 16

[[:fabrice] Fabrice Desré]

I agree with Etienne. Moving more things in the system app is not doable for 1.3t and is not desirable in general.

Comment 17

[Jesse]

Are there any other ways to shorten latency of opening oncall.html?

Comment 18

[Jesse]

I like the android activity. Could we open call screen html page directly like android start call screen activity registered in AndroidManifest.xml directly?  Opening oncall.html by way of dialer's index.html is a time of waste.