Closed Bug 981009 Opened 6 years ago Closed 6 years ago

Ensure the number of measurements match the number of RUNS.

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P1)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: hub, Assigned: hub)

References

Details

(Keywords: perf, Whiteboard: [c=automation p=1 s= u=])

Attachments

(1 file, 1 obsolete file)

Ensure the number of measurements match the number of RUNS.

This is to detect what bug 980978 and bug 980972 cause.

For example I get 3 perf duration for "startup event test > communications/contacts > startup > above-the-fold-ready" on a 5 launch run because, I think, of bug 980978.
Keywords: perf
Whiteboard: [c=automation p= s= u=]
Blocks: 980972
Assignee: nobody → hub
Status: NEW → ASSIGNED
Priority: -- → P1
No longer blocks: 980972
Blocks: 980972
No longer blocks: 980972
Whiteboard: [c=automation p= s= u=] → [c=automation p=1 s= u=]
Hub,

Is this still a problem now that bug 846909 (bug 980978) has landed? If not please resolve this, if so please push this to our 7.18 sprint.

Thanks,
Mike
Flags: needinfo?(hub)
I believe the problem might no longer occurs with the new listeners. BUT, we could add a validity check just to detect potential issues.
Flags: needinfo?(hub)
Depends on: 1038136
With the blocker, this is all I can do. 

The startup_event already check that we have results.
Attachment #8455325 - Flags: review?(eperelman)
Attachment #8455325 - Flags: review?(eperelman) → review+
Previous patch was wrong (and reverted)
Attachment #8455325 - Attachment is obsolete: true
Attachment #8456175 - Flags: review?(eperelman)
Attachment #8456175 - Flags: review?(eperelman) → review+
overfill_ratio_test.js needs a fix too. See blocker.
Work around blocker. Fix in:

https://github.com/mozilla-b2g/gaia/pull/22071
No longer depends on: 1038136
Depends on: 1042648
This was the last one.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.