Closed Bug 981009 Opened 6 years ago Closed 6 years ago
Ensure the number of measurements match the number of RUNS
46 bytes, text/x-github-pull-request
|Details | Review|
Ensure the number of measurements match the number of RUNS. This is to detect what bug 980978 and bug 980972 cause. For example I get 3 perf duration for "startup event test > communications/contacts > startup > above-the-fold-ready" on a 5 launch run because, I think, of bug 980978.
Assignee: nobody → hub
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [c=automation p= s= u=] → [c=automation p=1 s= u=]
Hub, Is this still a problem now that bug 846909 (bug 980978) has landed? If not please resolve this, if so please push this to our 7.18 sprint. Thanks, Mike
I believe the problem might no longer occurs with the new listeners. BUT, we could add a validity check just to detect potential issues.
With the blocker, this is all I can do. The startup_event already check that we have results.
Attachment #8455325 - Flags: review?(eperelman)
Previous patch was wrong (and reverted)
overfill_ratio_test.js needs a fix too. See blocker.
Work around blocker. Fix in: https://github.com/mozilla-b2g/gaia/pull/22071
No longer depends on: 1038136
This was the last one.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.