widget/src/windows/expose makefiles must specify OBJDIR

RESOLVED FIXED

Status

()

RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: jband_mozilla, Assigned: mozilla)

Tracking

({access})

Trunk
x86
Windows NT
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: need sr)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
The OBJS= lists in the two makefiles in the subdirs of widget/src/windows/expose 
need to specify OBJDIR in order to make the build system emit the obj, pdb, and 
other intermediate files to the right place. The current list will not 
distinguish between debug and release files. This is bad. I noticed this when I 
had my debug build running in the debugger and a background release build I was 
building failed because if could not open a .pdb file for writing that the 
debugger was using. This is not supposed to be the case.

I'll attach a proposed fix. Please follow through with the process to get it 
checked in if it works for you.
(Reporter)

Comment 1

17 years ago
Created attachment 48098 [details] [diff] [review]
proposed fixes for the two makefile.win files
(Assignee)

Comment 2

17 years ago
I'm applying the patch locally and will press for r/sr

thanks jband
Status: NEW → ASSIGNED
(Reporter)

Comment 3

17 years ago
If it looks right to you then you can r=jgaunt since you didn't write it. You 
just need an sr= and you're good for the trunk.
(Assignee)

Comment 4

17 years ago
r=me

shopping for sr now....
Keywords: access
Whiteboard: need sr
(Assignee)

Updated

17 years ago
Attachment #48098 - Flags: review+

Comment 5

17 years ago
Comment on attachment 48098 [details] [diff] [review]
proposed fixes for the two makefile.win files

sr=waterson
Attachment #48098 - Flags: superreview+
(Assignee)

Comment 6

17 years ago
checked in ( do we really need to require comments when resolving to fixed ? )
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.