981053 - Always pass CallArgs by reference

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

<bz> So if rval()
<bz> and then pass the CallArgs to someone
<bz> and they callee()
<bz> no assert
<bz> fail

Comment 1

[Jason Orendorff [:jorendorff]]

Can we store the extra bit on the stack instead? argv[-3], debug-only?

Too crazy?

Comment 2

[Nicolas B. Pierron [:nbp]]

Looking at the current status of this issue, this is still a thing, but minor:

https://searchfox.org/mozilla-central/search?q=CallArgs+args%2C&path=&case=false&regexp=false

All other variants seems to be gone.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 981053: Always pass CallArgs by reference. r=nbp!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6945c51bfe83
Always pass CallArgs by reference. r=nbp

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6945c51bfe83