981107 - Puppetize.sh should use --detailed-exit-codes

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The puppet-running scripts do a good job of parsing the exit codes from puppet, but puppetize.sh just (incorrectly) assumes that 'puppet agent' returns 0 only on success.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug981107.patch

Tested on a relabs system.

Comment 2

[Amy Rich [:arr] [:arich]]

Comment on attachment 8411892 [details] [diff] [review]
bug981107.patch

Looking through the script as a whole, there are a few cases where we shell out to populate variables but then don't actually check that the shell call worked and that the variables have data in them (see the mktemp above, plus a few calls to facter, etc).  We should add that checking.

Also, I'm not sure why PUPPET_OPTIONS doesn't include --detailed-exitcodes or --server since none of those things are used anyplace else in the script.  If there's a good reason for splitting them out, great, I'm just not sure what it is.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug981107-p2.patch

This checks the mktemp result, and puts all of the PUPPET_OPTIONS in one place.

Comment 4

[Amy Rich [:arr] [:arich]]

Comment on attachment 8411931 [details] [diff] [review]
bug981107-p2.patch

You want -f for the file test, not -d.  r+ with that change.