981116 - nsFlexContainerFrame member-var mChildrenHaveBeenReordered should probably be converted to a frame state bit

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

nsFlexContainerFrame has a member-var mChildrenHaveBeenReordered, added in bug  811521.

That variable should be converted to a frame state bit (one of the bits reserved for concrete frame classes), so that nsFlexContainerFrame instances can be a bit smaller.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8387872 [details] [diff] [review]
fix

Review of attachment 8387872 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFlexContainerFrame.h
@@ -25,1 @@
>    NS_DECL_QUERYFRAME

I think you may as well move NS_DECL_FRAMEARENA_HELPERS and NS_DECL_QUERYFRAME to the "public:" section too since they're public in nsFrame.

::: layout/generic/nsFrameStateBits.h
@@ +288,5 @@
> +
> +FRAME_STATE_GROUP(FlexContainer, nsFlexContainerFrame)
> +
> +// Set for a flex container whose children have been reordered due to 'order'.
> +// (Means that we have to be more thorough about checking them for sortedness).

"." inside the parens.

Comment 3

[Daniel Holbert [:dholbert]]

Addressed review comments and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a71fbcee972

Thanks for the review!

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a71fbcee972