Closed Bug 981116 Opened 7 years ago Closed 7 years ago

nsFlexContainerFrame member-var mChildrenHaveBeenReordered should probably be converted to a frame state bit

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

nsFlexContainerFrame has a member-var mChildrenHaveBeenReordered, added in bug  811521.

That variable should be converted to a frame state bit (one of the bits reserved for concrete frame classes), so that nsFlexContainerFrame instances can be a bit smaller.
Depends on: 811521
Assignee: nobody → dholbert
Attached patch fixSplinter Review
Attachment #8387872 - Flags: review?(cam)
Comment on attachment 8387872 [details] [diff] [review]
fix

Review of attachment 8387872 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFlexContainerFrame.h
@@ -25,1 @@
>    NS_DECL_QUERYFRAME

I think you may as well move NS_DECL_FRAMEARENA_HELPERS and NS_DECL_QUERYFRAME to the "public:" section too since they're public in nsFrame.

::: layout/generic/nsFrameStateBits.h
@@ +288,5 @@
> +
> +FRAME_STATE_GROUP(FlexContainer, nsFlexContainerFrame)
> +
> +// Set for a flex container whose children have been reordered due to 'order'.
> +// (Means that we have to be more thorough about checking them for sortedness).

"." inside the parens.
Attachment #8387872 - Flags: review?(cam) → review+
Addressed review comments and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a71fbcee972

Thanks for the review!
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/0a71fbcee972
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Blocks: 1361617
You need to log in before you can comment on or make changes to this bug.