Closed
Bug 981126
Opened 10 years ago
Closed 10 years ago
prevent glxtest child process from executing the normal shutdown sequence
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: vikstrous, Assigned: vikstrous)
References
Details
Attachments
(1 file, 1 obsolete file)
1.56 KB,
patch
|
Details | Diff | Splinter Review |
Right now the child process spawned by the glx test on Linux is making firefox shut down normally, which causes the profiler (given the MOZ_PROFLIER_SHUTDOWN environment variable) to try to write out its profile to disk. This leads to a deadlock on some operating systems. I was able to reproduce it on Ubuntu with kernel 3.2.0-45 and not on Arch Linux with 3.13.5-1-ARCH. The deadlock was happening on Talos, which was our original problem. We can't shut down the profiler either because that involves acquiring a lock. The only sane way to fix this appears to be to not execute the usual shut down sequence in the child process.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → vstanchev
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=25e31e85b370
Flags: needinfo?(bgirard)
Comment 3•10 years ago
|
||
Comment on attachment 8387861 [details] [diff] [review] glxtest Review of attachment 8387861 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/xre/glxtest.cpp @@ +260,4 @@ > close(pfd[1]); > return false; > } > + // the child exits early to avoid running to full shutdown sequence // to avoid conflicting with threads we have already spanned (like the profiler).
Attachment #8387861 -
Flags: review?(jmuizelaar)
Comment 4•10 years ago
|
||
Comment on attachment 8387861 [details] [diff] [review] glxtest Review of attachment 8387861 [details] [diff] [review]: ----------------------------------------------------------------- This is what I would've expected in the first place
Attachment #8387861 -
Flags: review?(jmuizelaar)
Attachment #8387861 -
Flags: review+
Attachment #8387861 -
Flags: feedback?(bjacob)
Updated•10 years ago
|
Flags: needinfo?(bgirard)
Updated•10 years ago
|
Attachment #8387861 -
Flags: feedback?(bjacob) → feedback+
Assignee | ||
Comment 5•10 years ago
|
||
Updated comment. Does anyone else need to review this?
Attachment #8387861 -
Attachment is obsolete: true
Flags: needinfo?(bgirard)
Comment 6•10 years ago
|
||
No, adding to my landing queue. Waiting on inbound.
Flags: needinfo?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/d736ff28e9dc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 984196
You need to log in
before you can comment on or make changes to this bug.
Description
•