981140 - Add identity.fxaccounts.remote.signup.uri pref for the FxA signup URL

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Chris Karlof [:ckarlof]]

Currently we use identity.fxaccounts.remote.uri, which uses a path of "/". IMO, it's better to be more explicit, because currently "/" doesn't route to any fixed state. The remote client side code makes a decision based on its local state. 

That may be a feature, but it can also lead to bugs. E.g., we are relying on "/" to redirect the user to "/signup". I propose the following:

Add a new pref: "identity.fxaccounts.remote.signup.uri" that maps to "/signup", and leave "identity.fxaccounts.remote.uri" as it is for when we want the page to decide what to show.

Comment 1

[Chris Karlof [:ckarlof]]

Attachment: 0001-Bug-981140-Make-the-FxA-signup-uri-pref-and-path-exp.patch

Comment 2

[Chris Karlof [:ckarlof]]

Attachment: 0001-Bug-981140-Make-the-FxA-signup-uri-pref-and-path-exp.patch

Comment 3

[Chris Karlof [:ckarlof]]

https://hg.mozilla.org/integration/fx-team/rev/0dd716985cd2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0dd716985cd2

Comment 5

[Chris Karlof [:ckarlof]]

Comment on attachment 8389449 [details] [diff] [review]
0001-Bug-981140-Make-the-FxA-signup-uri-pref-and-path-exp.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA Sync
User impact if declined: Easier to uplift future patches
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ed16a8be921