981172 - When browserid_identity.js encounters an AuthenticationError it should fire a "weave:service:login:error" notification

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Chris Karlof [:ckarlof]]

This functionality regressed in Bug 977502.

There are at least two significant listeners of "weave:service:login:error":
 
1) Sync UI, which uses it as a signal to update the "logged in" state
2) The SyncScheduler, which when Status.login enters an "unrecoverable state", like LOGIN_FAILED_LOGIN_REJECTED, then it stops scheduling syncs, which makes sense.

See https://bugzilla.mozilla.org/show_bug.cgi?id=977502#c19 for where it should probably be re-added.

Comment 1

[Chris Karlof [:ckarlof]]

> 2) The SyncScheduler, which when Status.login enters an "unrecoverable state", like LOGIN_FAILED_LOGIN_REJECTED, then it stops scheduling syncs, which makes sense.

http://hg.mozilla.org/mozilla-central/diff/35a1943f351c/services/sync/modules/policies.js#l1.128

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Patch was given r=ckarlof over-the-shoulder while bugzilla was down:

https://hg.mozilla.org/integration/fx-team/rev/dbc54ea4a407

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbc54ea4a407

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: As landed on central

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA Sync
User impact if declined: Sync UI will not be correct
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd9e870382e4