Closed Bug 981217 Opened 8 years ago Closed 8 years ago

mochitest on device, connection to wifi

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: onecyrenus, Assigned: onecyrenus)

Details

Attachments

(1 file, 1 obsolete file)

Made a modification to the way we connect to wifi to make the connection a bit more robust. 

The logic is below:


if no wifi settings are passed in, it assumes that the wifi network is already known. 

if wifi settings are passed in, we check through known networks to see if we already have stored credentials for that network.  if we find credentials we remove them, and attempt to connect. if the credentials are not found, then an attempt is made to connect.
Attached patch bug981217.patch (obsolete) — Splinter Review
Attachment #8387982 - Flags: review?(ahalberstadt)
https://tbpl.mozilla.org/?tree=Try&rev=a01945e65cf8, should be able to wait and see on the results. 

Also have turned off powersaving mode, which can sometimes kick in, in the middle of a run.
Comment on attachment 8387982 [details] [diff] [review]
bug981217.patch

Review of attachment 8387982 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits addressed.

::: testing/mochitest/b2g_start_script.js
@@ +92,5 @@
> +  manager.setPowerSavingMode(false);
> +
> +  manager.onenabled = function () {
> +    if(wifiSettings) {
> +      var req = manager.getKnownNetworks();

nit: use let instead of var, same for all other instances of var in this patch.

@@ +120,5 @@
> +       'wifi.suspended': false
> +     });
> +
> +    req.onsuccess = function () {
> +      dump("----------------------enabling wifi------------------\n");

Remove debug line.
Attachment #8387982 - Flags: review?(ahalberstadt) → review+
Attached patch bug981217.patchSplinter Review
nit fixes
Attachment #8387982 - Attachment is obsolete: true
Attachment #8389645 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/2522557e99a6

In the future, please make sure your patch has a useful commit message when requesting checkin :)
Assignee: nobody → dclarke
Keywords: checkin-needed
Bug 981217 - Make the wifi connection more rubust during testing . 

seems to explain the situation.
https://hg.mozilla.org/mozilla-central/rev/2522557e99a6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.