981217 - mochitest on device, connection to wifi

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[[e-mail] [:onecyrenus]]

Made a modification to the way we connect to wifi to make the connection a bit more robust. 

The logic is below:


if no wifi settings are passed in, it assumes that the wifi network is already known. 

if wifi settings are passed in, we check through known networks to see if we already have stored credentials for that network.  if we find credentials we remove them, and attempt to connect. if the credentials are not found, then an attempt is made to connect.

Comment 1

[[e-mail] [:onecyrenus]]

Attachment: bug981217.patch

Comment 2

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=a01945e65cf8, should be able to wait and see on the results. 

Also have turned off powersaving mode, which can sometimes kick in, in the middle of a run.

Comment 3

[Andrew Halberstadt [:ahal] (PTO Until Apr 3rd)]

Comment on attachment 8387982 [details] [diff] [review]
bug981217.patch

Review of attachment 8387982 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits addressed.

::: testing/mochitest/b2g_start_script.js
@@ +92,5 @@
> +  manager.setPowerSavingMode(false);
> +
> +  manager.onenabled = function () {
> +    if(wifiSettings) {
> +      var req = manager.getKnownNetworks();

nit: use let instead of var, same for all other instances of var in this patch.

@@ +120,5 @@
> +       'wifi.suspended': false
> +     });
> +
> +    req.onsuccess = function () {
> +      dump("----------------------enabling wifi------------------\n");

Remove debug line.

Comment 4

[[e-mail] [:onecyrenus]]

Attachment: bug981217.patch

nit fixes

Comment 5

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=d03e00933ca1 also try run results

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2522557e99a6

In the future, please make sure your patch has a useful commit message when requesting checkin :)

Comment 7

[[e-mail] [:onecyrenus]]

Bug 981217 - Make the wifi connection more rubust during testing . 

seems to explain the situation.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2522557e99a6