981219 - [B2G][FTE] The 'Select a Network' page during the FTE does not show a message when no networks are found

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[demerick]

Attachment: logcat.txt

Description:
If the user is not in range of any wireless networks during the First Time User experience there will be no message displayed on the 'Select a Network' page.

Repro Steps:
1) Update a Buri to BuildID: 20140307040203
2) If the device is not in the FTE process: Select Settings > Device Information > More Information > Reset Phone > OK
3) Isolate the device from WiFi signals (eg put it in a Faraday box)
4) Navigate to the 'Select a Network' page

Actual:
There is no message if no networks are found

Expected:
'No networks found' message should appear if no networks are located

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140307040203
Gaia: 04eb7996543f114133d1367f834a4d88b68c60ac
Gecko: b0e7f63c2138
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/5144/
See attached: screenshot, logcat

Comment 1

[demerick]

Attachment: 2014-03-07-19-36-31.png

Comment 2

[demerick]

This issue also occurs on the Buri v 1.3.0 Mozilla RIL

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140307004004
Gaia: e8bf7326ce5ed63bc8ef8b2cff1eba094887b9bf
Gecko: 4efa30fe00e7
Version: 28.0
Firmware Version: v1.2-device.cfg

During the FTE there is no message on the 'Select a Network page if no networks are located.

Comment 3

[Dean R. Gomez (DeanG)]

This issue DOES occur on Flame 1.4

1.4F Environmental Variables:
Device: Flame 1.4F
BuildID: 20140519000201
Gaia: defd0650fb9d30c6515d50a89e72d8fb74ce7e62
Gecko: d95594048b36
Version: 30.0
Firmware Version: v10F-3

Comment 4

[Dean R. Gomez (DeanG)]

While doing the LocRun2.0 on Tamil language, I was blocked from doing a test case due to this bug. 

This issue DOES occur on Flame 2.0:

2.0 Environmental Variables:
Device: Flame 2.0
Build ID: 20140630000201
Gaia: c0c8ad187c0466285f2580531e09f8322996f561
Gecko: d4dc609bcc8a
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Actual Result: The string for "No wireless networks found" does not appear.

Comment 5

[Francesco Lodolo [:flod]]

Kind of hard to reproduce nowadays (Wi-Fi everywhere).

We definitely have the string, code looks reasonable
https://github.com/mozilla-b2g/gaia/blob/master/apps/ftu/js/wifi.js#L295-L299

Only thing I can think of is that we never reach that code. Maybe related to bug 941071?

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Show a message when no networks are found

The main problem was in the if/else because using not operator (!) with an empty array it returns false, so the code was never reach

Comment 7

[Manuel Casas Barrado [:mancas]]

Attachment: no-wireless-found.png

Comment 8

[Fernando Campo (:fcampo)]

Comment on attachment 8460776 [details] [review]
Show a message when no networks are found

Thanks for taking care of this, Manuel.

Just a nit on the code (strict comparison), and add testing. Actually, fixing the test case that check this specific situation should be enough [https://github.com/mozilla-b2g/gaia/blob/master/apps/ftu/test/unit/wifi_test.js#L153-L159]

You also can add more test cases if you think it's worth the effort.

Comment 9

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8460776 [details] [review]
Show a message when no networks are found

I've made the changes you requested, so please take a look at the new commit.

Thanks

Comment 10

[Fernando Campo (:fcampo)]

Comment on attachment 8460776 [details] [review]
Show a message when no networks are found

Thanks for the quick modifications. Code looks great, works on device.

Let's wait for the green from try-server-hook results to merge.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/ae7e0f7891b67513a3a71b69dbc1da15f648407b

Comment 12

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.1
STR:
1. Select Settings > Device Information > Reset Phone > Reset.
2. Navigate to the 'Select a Network' page.
3. Connect a wifi with a wrong words.
4. Tap Refresh when wifi is connecting.
**It will show "No wireless networks found".
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880