Closed
Bug 981267
Opened 11 years ago
Closed 11 years ago
Bad indentation in about:networking
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: alex2august, Assigned: alex2august)
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
valentin
:
review+
sworkman
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140305030201
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8388051 -
Flags: review?(valentin.gosu)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8388051 [details] [diff] [review]
bad_indent.patch
Review of attachment 8388051 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Just note that patches need to be reviewed by a module peer - https://wiki.mozilla.org/Modules/Core
Also, the patch comment should usually look like "Bug 981267: Bad indentation in about:networking"
Attachment #8388051 -
Flags: review?(sworkman)
|
||
Comment 3•11 years ago
|
||
OK - weird. I tried to r+ this several times but bugzilla is giving me a 500 error.
r=me - Go ahead and land the patch with r=sworkman in the description.
|
|
||
Updated•11 years ago
|
Attachment #8388051 -
Flags: review?(valentin.gosu) → review+
|
|
||
Updated•11 years ago
|
Attachment #8388051 -
Flags: review?(sworkman) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → alex2august
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•