981274 - KumaScript macros like {{ $something }} shouldn't be allowed

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: KumaScript, defect, P2)

Description

[Florian Scholz (Open Web Docs)]

What did you do?
================
1. Wondered why some pages had an Internal Server Error. 
2. Found out that these docs had "{{ $something }}" in the content. 
3. Looked at New Relic with Luke to see what's going on.
4. Found out that a macro with a "$" is an invalid call.

What happened?
==============
ISE.

What should have happened?
==========================
No ISE. Do not allow macro names with "$" (and maybe other special chars?)

Is there anything else we should know?
======================================
The macros are escaped in the content now: \{{ $something }}

Comment 1

[Florian Scholz (Open Web Docs)]

Bumping severity as discussed with Maris earlier to today. This *might* be an edge case but it is breaking the site with an Internal Server Error and the document is unreachable when it comes to this case.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/8a73c55540ff8dc9b681fd3b3b41c7cc9790bfd2
bug 981274: Quick fix for ISE when $ used in macro names

https://github.com/mozilla/kuma/commit/7758e86799cf7eaf957235383528b0eb88924a1b
Merge pull request #2130 from lmorchard/981274-fix-dollar-template-error

bug 981274: Quick fix for ISE when $ used in macro names

Comment 3

[Florian Scholz (Open Web Docs)]

Fixed in https://github.com/mozilla/kuma/pull/2130, see comment 2.