Closed Bug 981328 Opened 10 years ago Closed 10 years ago

[Search] XHR mock is not restored

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review 
We currently set a xhr mock in marketplace_test.js, but do not restore it. This may be causing problems while running with test coverage.
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8388108 [details] [review]
Github pull request

Hey Ricky - would you have time to put a review stamp on this one? Thanks!

        Attachment #8388108 -
        Flags: review?(ricky060709)

    
    

    
  
Comment on attachment 8388108 [details] [review]
Github pull request

Fix is same as mine:)

        Attachment #8388108 -
        Flags: review?(ricky060709) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/9b463c17899155d55a77c0d47a11845c0aab1b1b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: