981354 - Move googleanalytics into separate file in popcorn.webmaker

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Alexander [:admix]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9




Expected results:

Move googleanalytics into separate file in popcorn.webmaker
https://github.com/mozilla/popcorn.webmaker.org/blob/master/views/googleanalytics.html

Comment 1

[Alexander [:admix]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/488

Moved google-analytics into separate file.
PR -> https://github.com/mozilla/popcorn.webmaker.org/pull/488

Comment 2

[Jon Buckley [:jbuck]]

Comment on attachment 8388153 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/488

r-, notes in the PR

Comment 3

[Alexander [:admix]]

Comment on attachment 8388153 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/488

Fixed formatting and typo.
PR - https://github.com/mozilla/popcorn.webmaker.org/pull/488

Comment 4

[Alexander [:admix]]

I know it was r+.
However, Travis was not happy with commits, the warning was about the single quotes and trailing space, I fixed that and pushed an update. Should be fine. PR -> https://github.com/mozilla/popcorn.webmaker.org/pull/488
If ok, I can merge it.

Comment 5

[Jon Buckley [:jbuck]]

Yeah, looks good. Merge it!

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/8058bb4030043a9445093d83c5c0cb0ceb436f7c
[bug981354] - Moved google-analytics inline script into separate file

[bug981354] - formatting and typo fixes

[bug981354] - fixed styling and formatting for Travis

https://github.com/mozilla/popcorn.webmaker.org/commit/06ee7a3e5916dae1e3c1e9d53144cea566fc7f37
Merge pull request #488 from admix/bug981354

[bug981354] - Moved google-analytics inline script into separate file

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/70b17ecce05c7e2cca49f6da9e6a73b8f8c47547
Bug 981354 - Add ga script to error page