981357 - Move friendly code inline script into separate file in Thimble

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Alexander [:admix]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9




Expected results:

Move friendly code inline script into separate file.
https://github.com/mozilla/thimble.webmaker.org/blob/master/views/friendlycode.html#L07-L108

Comment 1

[Alexander [:admix]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/389

Moved inline friendlycode script into separate file
PR -> https://github.com/mozilla/thimble.webmaker.org/pull/389

Comment 2

[Jon Buckley [:jbuck]]

Comment on attachment 8388205 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/389

r-, comments in PR

Comment 3

[Alexander [:admix]]

Comment on attachment 8388205 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/389

Wrapped in function.
PR - https://github.com/mozilla/thimble.webmaker.org/pull/389

Comment 4

[Alexander [:admix]]

PR is updated again.

Comment 5

[Pomax]

Comment on attachment 8388205 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/389

don't use data-attributes on the script element, just have nunjucks render the friendlycode.js file instead, the same way it's rendering any other view. Place friendlycode.js in the views directory (possibly in a js subdir) and then have the friendlycode.html include it from there rather than from the public/js dir.

Comment 6

[Alexander [:admix]]

Comment on attachment 8388205 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/389

Hey Jon, is this one good to go? After some discussion with Scott, is there any other solution I should look at or you can suggest?! Or for now, this will be the best that could be done? Thanks.
PR - https://github.com/mozilla/thimble.webmaker.org/pull/389

Comment 7

[Jon Buckley [:jbuck]]

Comment on attachment 8388205 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/389

Yeah, this is good to go, Pomax and I hashed out this solution in IRC and came to the conclusion that it's one the least-bad options :)

Comment 8

[Jon Buckley [:jbuck]]

Make sure you rebase this before it lands

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/b3560b2cbcdf4e6e6696f81b246b0bf4667b5329
[bug981357] - Moved inline friendlycode script into separate js file

[bug981357] - removed useless comments

[bug981357] - wrapped in function to keep variables local

[bug981357] - fixed url for remixURLTemplate

https://github.com/mozilla/thimble.webmaker.org/commit/28929a9ed6cfddc908d9dde37994696799c04dc6
Merge pull request #389 from admix/bug981357

[bug981357] - Moved inline friendlycode script into separate js file