981427 - CppEclipse usability improvements for b2g

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #981411 +++

This fixes the build system, launch configuration, disables the scanner (slow and useless).

Comment 1

[Botond Ballo [:botond]]

Comment on attachment 8388227 [details] [diff] [review]
patch

Review of attachment 8388227 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ +139,5 @@
> +                launch = launch.replace('@LAUNCH_PROGRAM@', exe_path)
> +                launch = launch.replace('@LAUNCH_ARGS@', '-P -no-remote')
> +                fh.write(launch)
> +
> +        if self.environment.substs['MOZ_WIDGET_TOOLKIT'] == 'gonk':

Any reason this isn't an 'else' to the above 'if'?

Comment 2

[Benoit Girard (:BenWa)]

Because in the future it's going to be a if desktop ... elseif fennec elseif gonk.

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed9102a0b2f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ed9102a0b2f